-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Root Disk Image lookup should use a filter on image name rather than family when Version is specified but Spec.Image and Spec.ImageFamily are not #293
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/lifecycle frozen |
/help |
@detiber: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
/assign |
/kind bug
What steps did you take and what happened:
When only GCPMachine.Spec.Version is defined (without also defining Spec.Image or Spec.ImageFamily), the root disk lookup defaults to using image family, which groups all images by kubernetes major and minor versions (ignoring patch version), instead we should fall back to using filtering on the name to also include the patch version as well as sorting by creation timestamp to choose the newest image that matches the kubernetes major/minor/patch version combination.
The text was updated successfully, but these errors were encountered: