Root Disk Image lookup should use a filter on image name rather than family #597

aniruddha2000 · 2022-05-09T17:02:05Z

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR look for Spec.Image instead of Spec.ImageFamily when when Version is specified but Spec.Image and Spec.ImageFamily are not. Also it include the patch version as well instead of current major minor version.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #293

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

squashed commits
includes documentation
adds unit tests

Release note:

Root Disk Image lookup should use a filter on image name rather than family and include patch version

Signed-off-by: Aniruddha Basak <[email protected]>

k8s-ci-robot · 2022-05-09T17:02:13Z

Hi @aniruddha2000. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cpanato · 2022-05-10T08:28:38Z

/ok-to-test

cpanato · 2022-05-10T09:01:14Z

/test ls

k8s-ci-robot · 2022-05-10T09:01:16Z

@cpanato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-gcp-build
/test pull-cluster-api-provider-gcp-e2e-test
/test pull-cluster-api-provider-gcp-make
/test pull-cluster-api-provider-gcp-test
/test pull-cluster-api-provider-gcp-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-gcp-apidiff
/test pull-cluster-api-provider-gcp-capi-e2e
/test pull-cluster-api-provider-gcp-conformance
/test pull-cluster-api-provider-gcp-conformance-ci-artifacts
/test pull-cluster-api-provider-gcp-coverage
/test pull-cluster-api-provider-gcp-e2e-workload-upgrade

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-gcp-apidiff
pull-cluster-api-provider-gcp-build
pull-cluster-api-provider-gcp-e2e-test
pull-cluster-api-provider-gcp-make
pull-cluster-api-provider-gcp-test
pull-cluster-api-provider-gcp-verify

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cpanato · 2022-05-10T09:01:25Z

/test pull-cluster-api-provider-gcp-capi-e2e
/test pull-cluster-api-provider-gcp-conformance

cpanato · 2022-05-10T10:21:37Z

thanks
/approve
/assign @pydctw

k8s-ci-robot · 2022-05-10T10:21:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aniruddha2000, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cpanato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pydctw · 2022-05-13T17:34:41Z

I don't have much context on image side of CAPG but reading the issue, how are multiple images with same version but different time stamps are handled? @aniruddha2000

we should fall back to using filtering on the name to also include the patch version as well as sorting by creation timestamp to choose the newest image that matches the kubernetes major/minor/patch version combination.

aniruddha2000 · 2022-05-13T18:26:31Z

@pydctw Here it is said that -

specify family/debian-9 to use the latest Debian 9 image:
projects/debian-cloud/global/images/family/debian-9 Alternatively,
use a specific version of a public operating system image:
projects/debian-cloud/global/images/debian-9-stretch-vYYYYMMDD To
create a disk with a custom image that you created

Looks like projects/my-proj/global/images/family/capi-ubuntu-1804-k8s-v1-19 will always pick the latest by default according to the implementation and we can specify the projects/my-proj/global/images/family/capi-ubuntu-1804-k8s-v1-19-vYYYYMMDD to get the specific date image.

I also have no context of CAPG image so feel free to correct me if I am wrong 😅

aniruddha2000 · 2022-07-11T17:35:29Z

/cc @pydctw

k8s-triage-robot · 2022-10-09T17:50:16Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-11-08T18:13:31Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2022-12-08T18:49:17Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2022-12-08T18:49:21Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aniruddha2000 added 2 commits May 9, 2022 22:20

Lookup spec.image and include patch version

2cabfd6

Signed-off-by: Aniruddha Basak <[email protected]>

Add test for lookup image instead of imageFamily and include patch

03577cf

Signed-off-by: Aniruddha Basak <[email protected]>

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 9, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2022

k8s-ci-robot requested a review from cpanato May 9, 2022 17:02

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 9, 2022

k8s-ci-robot requested a review from fabriziopandini May 9, 2022 17:02

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 10, 2022

k8s-ci-robot assigned pydctw May 10, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022

k8s-ci-robot requested a review from pydctw July 11, 2022 17:35

aniruddha2000 mentioned this pull request Sep 15, 2022

REQUEST: New membership for aniruddha2000 kubernetes/org#3698

Closed

9 tasks

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 9, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 8, 2022

k8s-ci-robot closed this Dec 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Root Disk Image lookup should use a filter on image name rather than family #597

Root Disk Image lookup should use a filter on image name rather than family #597

aniruddha2000 commented May 9, 2022

k8s-ci-robot commented May 9, 2022

cpanato commented May 10, 2022

cpanato commented May 10, 2022

k8s-ci-robot commented May 10, 2022

cpanato commented May 10, 2022

cpanato commented May 10, 2022

k8s-ci-robot commented May 10, 2022

pydctw commented May 13, 2022

aniruddha2000 commented May 13, 2022

aniruddha2000 commented Jul 11, 2022

k8s-triage-robot commented Oct 9, 2022

k8s-triage-robot commented Nov 8, 2022

k8s-triage-robot commented Dec 8, 2022

k8s-ci-robot commented Dec 8, 2022

Root Disk Image lookup should use a filter on image name rather than family #597

Root Disk Image lookup should use a filter on image name rather than family #597

Conversation

aniruddha2000 commented May 9, 2022

k8s-ci-robot commented May 9, 2022

cpanato commented May 10, 2022

cpanato commented May 10, 2022

k8s-ci-robot commented May 10, 2022

cpanato commented May 10, 2022

cpanato commented May 10, 2022

k8s-ci-robot commented May 10, 2022

pydctw commented May 13, 2022

aniruddha2000 commented May 13, 2022

aniruddha2000 commented Jul 11, 2022

k8s-triage-robot commented Oct 9, 2022

k8s-triage-robot commented Nov 8, 2022

k8s-triage-robot commented Dec 8, 2022

k8s-ci-robot commented Dec 8, 2022