Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link-check test failing due to a broken link. #620

Open
jayesh-srivastava opened this issue Jun 7, 2022 · 10 comments
Open

Link-check test failing due to a broken link. #620

jayesh-srivastava opened this issue Jun 7, 2022 · 10 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@jayesh-srivastava
Copy link
Member

/kind bug

What steps did you take and what happened:
Link-check/Broken Links test is failing due to a broken link in releasing.md.

What did you expect to happen:
The correct link should be added so the test could pass.

Anything else you would like to add:
At line 17, the existing link should be replaced with https://docs.github.com/en/authentication/managing-commit-signature-verification/generating-a-new-gpg-key

Environment:

  • Cluster-api version:
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 7, 2022
@jayesh-srivastava
Copy link
Member Author

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@jayesh-srivastava:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 7, 2022
@Aayush987
Copy link
Contributor

/assign

@Anubhavdevv
Copy link

I would like to contribute to it

@Aayush987
Copy link
Contributor

I would like to contribute to it

I have almost made the pr with the applied changes. You can look out for other good first issues on the issues tab.

@jayesh-srivastava
Copy link
Member Author

@Anubhavdevv Looks like you're a bit late. @Aayush987 had already assigned this to himself. You can always look for other issues.

@Anubhavdevv
Copy link

ok no issues

@SD-13
Copy link

SD-13 commented Aug 19, 2022

Hey @jayesh-srivastava, is this issue still available?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2023
@bubbaksmith
Copy link

This issue has been solved and can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants