Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update k8s version for testing and go to 1.20.8 #1018

Merged
merged 5 commits into from
Oct 23, 2023
Merged

update k8s version for testing and go to 1.20.8 #1018

merged 5 commits into from
Oct 23, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Sep 15, 2023 •
edited
Loading

/kind feature
/kind failing-test

What this PR does / why we need it:

  • update k8s version for testing and go to 1.20.8
    /hold for all tests

/assign @richardcase

Fixes: #1016

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

update k8s version for testing and go to 1.20.8

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 15, 2023
@richardcase
Copy link
Member

/test pull-cluster-api-provider-gcp-test

@cpanato
Copy link
Member Author

cpanato commented Sep 15, 2023

humm, interesting, here it is passing #1019

@cpanato
Copy link
Member Author

cpanato commented Sep 15, 2023

humm, interesting, here it is passing #1019

was the KUBEBUILDER_ENVTEST_KUBERNETES_VERSION, reverted, maybe we need to look if we need to upgrade this

@cpanato
Copy link
Member Author

cpanato commented Sep 15, 2023

/test ls

@k8s-ci-robot
Copy link
Contributor

@cpanato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-gcp-build
  • /test pull-cluster-api-provider-gcp-e2e-test
  • /test pull-cluster-api-provider-gcp-make
  • /test pull-cluster-api-provider-gcp-test
  • /test pull-cluster-api-provider-gcp-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-gcp-apidiff
  • /test pull-cluster-api-provider-gcp-capi-e2e
  • /test pull-cluster-api-provider-gcp-conformance
  • /test pull-cluster-api-provider-gcp-conformance-ci-artifacts
  • /test pull-cluster-api-provider-gcp-coverage
  • /test pull-cluster-api-provider-gcp-coverage-release-1-3
  • /test pull-cluster-api-provider-gcp-coverage-release-1-4
  • /test pull-cluster-api-provider-gcp-e2e-workload-upgrade

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-gcp-apidiff
  • pull-cluster-api-provider-gcp-build
  • pull-cluster-api-provider-gcp-e2e-test
  • pull-cluster-api-provider-gcp-make
  • pull-cluster-api-provider-gcp-test
  • pull-cluster-api-provider-gcp-verify

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member Author

cpanato commented Sep 15, 2023

/test pull-cluster-api-provider-gcp-conformance

@richardcase
Copy link
Member

For the panic we can add ctrl.SetLogger(klog.Background()) at the beginning of TestE2E.

@cpanato
Copy link
Member Author

cpanato commented Sep 15, 2023

For the panic we can add ctrl.SetLogger(klog.Background()) at the beginning of TestE2E.

which panic? 🤔

@richardcase
Copy link
Member

which panic? 🤔

Actually its not a panic, just an error:

 [controller-runtime] log.SetLogger(...) was never called, logs will not be displayed:
goroutine 82 [running]:
runtime/debug.Stack()

Sorry for the panic.

@richardcase
Copy link
Member

Great work @cpanato , thanks for sorting this so quick. How did you know it was a problem with the versions?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2023
@cpanato
Copy link
Member Author

cpanato commented Sep 15, 2023

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

@cpanato
Copy link
Member Author

cpanato commented Sep 15, 2023

Great work @cpanato , thanks for sorting this so quick. How did you know it was a problem with the versions?

/lgtm

to be honest just the feeling 😅

@cpanato
Copy link
Member Author

cpanato commented Sep 15, 2023

humm but looks like it is something else in the ci-artifacts job @richardcase will take a look closer

@cpanato
Copy link
Member Author

cpanato commented Sep 15, 2023

found

p kubernetes_semver=v1.29.0-alpha.0.819+bad6b29b9b7a26 kubernetes_source_type=http kubernetes_load_additional_imgs=false kubernetes_deb_version=1.26.7-1.1 kubernetes_rpm_version=1.26.7 no_proxy= pip_conf_file= python_path= redhat_epel_rpm=https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm epel_rpm_gpg_key= reenable_public_repos=true remove_extra_repos=false systemd_prefix=/usr/lib/systemd sysusr_prefix=/usr sysusrlocal_prefix=/usr/local load_additional_components=false additional_registry_images=false additional_registry_images_list= additional_url_images=false additional_url_images_list= additional_executables=false additional_executables_list= additional_executables_destination_path= additional_s3=false build_target=virt amazon_ssm_agent_rpm= enable_containerd_audit= --extra-vars  --extra-vars  --scp-extra-args  -e ansible_ssh_private_key_file=/tmp/ansible-key1827483788 -i /tmp/packer-provisioner-ansible1342639147 /home/prow/go/src/sigs.k8s.io/image-builder/images/capi/ansible/node.yml

fixing

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 15, 2023
@cpanato
Copy link
Member Author

cpanato commented Oct 20, 2023

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

@cpanato
Copy link
Member Author

cpanato commented Oct 21, 2023

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts
/test pull-cluster-api-provider-gcp-make
/test pull-cluster-api-provider-gcp-build

@cpanato
Copy link
Member Author

cpanato commented Oct 21, 2023

/test pull-cluster-api-provider-gcp-verify
/test pull-cluster-api-provider-gcp-test

@cpanato cpanato marked this pull request as ready for review October 21, 2023 12:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2023
@cpanato
Copy link
Member Author

cpanato commented Oct 21, 2023

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

@cpanato cpanato force-pushed the update-k8s-test branch 2 times, most recently from 4e612b3 to 08d7fbe Compare October 21, 2023 16:28
@cpanato
Copy link
Member Author

cpanato commented Oct 22, 2023

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

@cpanato
Copy link
Member Author

cpanato commented Oct 22, 2023 •
edited
Loading

passed: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-gcp/1018/pull-cluster-api-provider-gcp-conformance-ci-artifacts/1716063797619200000

re-running

@cpanato
Copy link
Member Author

cpanato commented Oct 22, 2023

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

@cpanato
Copy link
Member Author

cpanato commented Oct 22, 2023

success the ci-artifacts test, final re-test

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts

@cpanato
Copy link
Member Author

cpanato commented Oct 22, 2023

this should be ready now @richardcase the pull-cluster-api-provider-gcp-conformance-ci-artifacts is now running fine, run 4-5 times with success

/unhold

@richardcase PTAL
cc @aojea
any improvements and other things i think we can do in a follow up

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2023
@aojea
Copy link

aojea commented Oct 22, 2023

+1 to the best of my knowledge ;)

richardcase
richardcase reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @cpanato 🥇 And thats very interesting about cloud.config.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit c82901c into kubernetes-sigs:main Oct 23, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Oct 23, 2023
@cpanato cpanato deleted the update-k8s-test branch October 23, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase richardcase left review comments

@aojea aojea aojea left review comments

@dims dims Awaiting requested review from dims

Assignees

@richardcase richardcase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

[e2e] Failing test capg-conformance-main-ci-artifacts - No Control Plane machines came into existence
5 participants
@cpanato @k8s-ci-robot @richardcase @ameukam @aojea