add sharedvpc support for lb subnet #1280

swarren83 · 2024-07-01T16:07:22Z

What type of PR is this?

What this PR does / why we need it:
Add support for SharedVPC when specifying spec.loadBalancer.internalLoadBalancer.subnet

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1279

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

squashed commits
includes documentation
adds unit tests

Release note:

NONE

linux-foundation-easycla · 2024-07-01T16:07:26Z

The committers listed above are authorized under a signed CLA.

✅ login: swarren83 / name: Shawn Warren (0207069)

k8s-ci-robot · 2024-07-01T16:07:31Z

Welcome @swarren83!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-gcp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-gcp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-07-01T16:07:31Z

Hi @swarren83. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2024-07-01T16:07:38Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name	Link
🔨 Latest commit	`0207069`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/66902ec8420e0700071260b7
😎 Deploy Preview	https://deploy-preview-1280--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

swarren83 · 2024-07-01T16:10:50Z

/hold

swarren83 · 2024-07-01T16:14:02Z

/easycla

cloud/services/compute/loadbalancers/service.go

swarren83 · 2024-07-01T18:17:05Z

/hold cancel

cpanato · 2024-07-02T12:14:26Z

please sign the cla

/ok-to-test

swarren83 · 2024-07-02T16:39:42Z

@cpanato I need to wait on merging this. I need to work on switching to the Corporate CLA.

swarren83 · 2024-07-03T14:31:44Z

/hold cancel

swarren83 · 2024-07-03T14:32:24Z

@cpanato Ready to proceed if this lgtm.

cpanato

/assign @damdo

/approve

k8s-ci-robot · 2024-07-04T12:14:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, swarren83

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cpanato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cpanato · 2024-07-04T12:14:34Z

/hold for @damdo review as well

swarren83 · 2024-07-08T18:14:28Z

Wanted to follow up on the status of this PR, @damdo do you have any additional requirements of me to earn your approval?

barbacbd

After testing this feature change, I believe that I was mistaken and we only need subnets to change the cloud scope.

cloud/services/compute/loadbalancers/service.go

swarren83 · 2024-07-11T16:52:43Z

@barbacbd I have reverted the changes to scope regional health checks and target tcp proxies.

barbacbd · 2024-07-11T18:11:36Z

@barbacbd I have reverted the changes to scope regional health checks and target tcp proxies.

@swarren83 I would probably rebase it so that there is only one commit. Otherwise LGTM. @cpanato PTAL Thank you!

fix: set cloudScope for regionalhc and tgttcpproxies add test for lb w/ shared vpc add more test cases revert regionlhc and targettcpproxies

swarren83 · 2024-07-22T14:36:44Z

@barbacbd I rebased to a single commit as requested. Do we need anything else to get this ready to merge?

barbacbd · 2024-07-22T16:36:39Z

@barbacbd I rebased to a single commit as requested. Do we need anything else to get this ready to merge?

I am good with this change. I do not have LGTM or Approval privileges in this repo. @damdo or @cpanato can you take a look please?

damdo

Thanks for your PR @swarren83

/lgtm
/unhold

This picks up fix for shared VPC and labels, particularly: kubernetes-sigs/cluster-api-provider-gcp#1280 kubernetes-sigs/cluster-api-provider-gcp#1277 kubernetes-sigs/cluster-api-provider-gcp#1275

k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 1, 2024

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 1, 2024

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 1, 2024

k8s-ci-robot requested review from damdo and dims July 1, 2024 16:07

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 1, 2024

swarren83 changed the title ~~add sharedvpc support for lb subnet~~ DRAFT: add sharedvpc support for lb subnet Jul 1, 2024

swarren83 changed the title ~~DRAFT: add sharedvpc support for lb subnet~~ WIP: add sharedvpc support for lb subnet Jul 1, 2024

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2024

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2024

barbacbd reviewed Jul 1, 2024

View reviewed changes

cloud/services/compute/loadbalancers/service.go Show resolved Hide resolved

barbacbd reviewed Jul 1, 2024

View reviewed changes

cloud/services/compute/loadbalancers/service.go Show resolved Hide resolved

swarren83 force-pushed the 1279/lb/add-sharedvpc-support branch from 1ebb54b to 5492ae7 Compare July 1, 2024 18:13

swarren83 changed the title ~~WIP: add sharedvpc support for lb subnet~~ add sharedvpc support for lb subnet Jul 1, 2024

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2024

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2024

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2024

cpanato reviewed Jul 4, 2024

View reviewed changes

k8s-ci-robot assigned damdo Jul 4, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2024

barbacbd reviewed Jul 11, 2024

View reviewed changes

cloud/services/compute/loadbalancers/service.go Outdated Show resolved Hide resolved

cloud/services/compute/loadbalancers/service.go Outdated Show resolved Hide resolved

swarren83 force-pushed the 1279/lb/add-sharedvpc-support branch from 0f16b9e to e6001db Compare July 11, 2024 16:51

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2024

feat: add sharedvpc support for lb subnet

0207069

fix: set cloudScope for regionalhc and tgttcpproxies add test for lb w/ shared vpc add more test cases revert regionlhc and targettcpproxies

swarren83 force-pushed the 1279/lb/add-sharedvpc-support branch from e6001db to 0207069 Compare July 11, 2024 19:13

damdo reviewed Jul 24, 2024

View reviewed changes

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 24, 2024

k8s-ci-robot merged commit b725302 into kubernetes-sigs:main Jul 24, 2024
16 checks passed

k8s-ci-robot added this to the v1.1.0 milestone Jul 24, 2024

bfournie mentioned this pull request Jul 26, 2024

OCPBUGS-35262: Upgrade to latest cluster-api-provider-gcp openshift/installer#8780

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add sharedvpc support for lb subnet #1280

add sharedvpc support for lb subnet #1280

swarren83 commented Jul 1, 2024 •

edited

Loading

linux-foundation-easycla bot commented Jul 1, 2024 •

edited

Loading

k8s-ci-robot commented Jul 1, 2024

k8s-ci-robot commented Jul 1, 2024

netlify bot commented Jul 1, 2024 •

edited

Loading

swarren83 commented Jul 1, 2024

swarren83 commented Jul 1, 2024

swarren83 commented Jul 1, 2024

cpanato commented Jul 2, 2024

swarren83 commented Jul 2, 2024 •

edited

Loading

swarren83 commented Jul 3, 2024

swarren83 commented Jul 3, 2024

cpanato left a comment

k8s-ci-robot commented Jul 4, 2024

cpanato commented Jul 4, 2024

swarren83 commented Jul 8, 2024

barbacbd left a comment

swarren83 commented Jul 11, 2024

barbacbd commented Jul 11, 2024

swarren83 commented Jul 22, 2024

barbacbd commented Jul 22, 2024

damdo left a comment

add sharedvpc support for lb subnet #1280

add sharedvpc support for lb subnet #1280

Conversation

swarren83 commented Jul 1, 2024 • edited Loading

linux-foundation-easycla bot commented Jul 1, 2024 • edited Loading

k8s-ci-robot commented Jul 1, 2024

k8s-ci-robot commented Jul 1, 2024

netlify bot commented Jul 1, 2024 • edited Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

swarren83 commented Jul 1, 2024

swarren83 commented Jul 1, 2024

swarren83 commented Jul 1, 2024

cpanato commented Jul 2, 2024

swarren83 commented Jul 2, 2024 • edited Loading

swarren83 commented Jul 3, 2024

swarren83 commented Jul 3, 2024

cpanato left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 4, 2024

cpanato commented Jul 4, 2024

swarren83 commented Jul 8, 2024

barbacbd left a comment

Choose a reason for hiding this comment

swarren83 commented Jul 11, 2024

barbacbd commented Jul 11, 2024

swarren83 commented Jul 22, 2024

barbacbd commented Jul 22, 2024

damdo left a comment

Choose a reason for hiding this comment

swarren83 commented Jul 1, 2024 •

edited

Loading

linux-foundation-easycla bot commented Jul 1, 2024 •

edited

Loading

netlify bot commented Jul 1, 2024 •

edited

Loading

swarren83 commented Jul 2, 2024 •

edited

Loading