-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement GCPManagedCluster reconciliation (GKE Part 2) #787
Conversation
af6c62c
to
d60f4cd
Compare
d60f4cd
to
7163b71
Compare
When PR 1 merges i will rebase this and remove the feature flag / main changes and put those in a later PR. fyi @richardchen331 |
As the GKE support isn't released we can ignore apidiff errors: /override pull-cluster-api-provider-gcp-apidiff |
@richardcase: Overrode contexts on behalf of richardcase: pull-cluster-api-provider-gcp-apidiff In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks cool
a very small nit
Signed-off-by: Richard Case <[email protected]>
Thanks @cpanato, i made the nit changes. |
/override pull-cluster-api-provider-gcp-apidiff |
@richardcase: Overrode contexts on behalf of richardcase: pull-cluster-api-provider-gcp-apidiff In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This change adds the reconciliation logic for the
GCPManagedCluster
. Also it adds a GKE feature gate and uses that gate to start controllers/webhooks.NOTE: this won't be enabled until a later PR with the feature flag.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Relates #512
Special notes for your reviewer:
Not fully tested yet.
TODOs:
Release note: