From eb478943e98cdda5174f2dcbb1da993e9f5033dc Mon Sep 17 00:00:00 2001 From: Stefan Bueringer Date: Fri, 28 Jul 2023 11:09:53 +0200 Subject: [PATCH] Deprecate AutoConfigure functionality --- .golangci.yml | 5 +++++ apis/v1beta1/vspherefailuredomain_types.go | 2 ++ ...ructure.cluster.x-k8s.io_vspherefailuredomains.yaml | 10 ++++++---- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 1908b771d1..e4b97b0ba5 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -52,6 +52,11 @@ issue: max-per-linter: 0 issues: exclude-rules: + # Specific exclude rules for deprecated fields that are still part of the codebase. These + # should be removed as the referenced deprecated item is removed from the project. + - linters: + - staticcheck + text: "SA1019: failureDomain.AutoConfigure is deprecated" - path: "test/e2e/*" linters: - gosec diff --git a/apis/v1beta1/vspherefailuredomain_types.go b/apis/v1beta1/vspherefailuredomain_types.go index 4151fe3926..7c458941ef 100644 --- a/apis/v1beta1/vspherefailuredomain_types.go +++ b/apis/v1beta1/vspherefailuredomain_types.go @@ -54,6 +54,8 @@ type FailureDomain struct { TagCategory string `json:"tagCategory"` // AutoConfigure tags the Type which is specified in the Topology + // + // Deprecated: This field is going to be removed in a future release. AutoConfigure *bool `json:"autoConfigure,omitempty"` } diff --git a/config/default/crd/bases/infrastructure.cluster.x-k8s.io_vspherefailuredomains.yaml b/config/default/crd/bases/infrastructure.cluster.x-k8s.io_vspherefailuredomains.yaml index 1f5fb2fd7d..3733733030 100644 --- a/config/default/crd/bases/infrastructure.cluster.x-k8s.io_vspherefailuredomains.yaml +++ b/config/default/crd/bases/infrastructure.cluster.x-k8s.io_vspherefailuredomains.yaml @@ -283,8 +283,9 @@ spec: description: Region defines the name and type of a region properties: autoConfigure: - description: AutoConfigure tags the Type which is specified in - the Topology + description: "AutoConfigure tags the Type which is specified in + the Topology \n Deprecated: This field is going to be removed + in a future release." type: boolean name: description: Name is the name of the tag that represents this @@ -347,8 +348,9 @@ spec: description: Zone defines the name and type of a zone properties: autoConfigure: - description: AutoConfigure tags the Type which is specified in - the Topology + description: "AutoConfigure tags the Type which is specified in + the Topology \n Deprecated: This field is going to be removed + in a future release." type: boolean name: description: Name is the name of the tag that represents this