Adding feature gate EnableKeepAlive back to release 1.5 and release 1.6

[zhanggbj]

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
This is found during manual cherry-pick #2154 back to release-1.5 and release 1.6 as auto cherry-pick has conflicts. It turns out that old release don't have feature gate EnableKeepAlive, this is introduced in release 1.7 by a324391.

What did you expect to happen:
Better to introduce the feature gate in release-1.5 and release 1.6.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

• Cluster-api-provider-vsphere version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

[sbueringer]

Based on the explanation in #1896 (comment), sounds good to me.

Also should be a backward-compatible change as we just introduce a new flag that and it defaults to the current behavior (true).

Feel free to go ahead with this

[sbueringer]

(I wouldn't call this a bug though :))

[sbueringer]

If I see correctly afterwards the session handling would be identical across branches (?)

[zhanggbj]

Sure, so will continue to add the feature gate and set to true so ensure there's no behavior change :)

This is the only thing that causing conflicts I met today, so I assume after this change, session handling should be identical.

/kind feature
/assign

[zhanggbj]

/remove-kind bug

[sbueringer]

Thx!

/close
all cherry-picks merged

[k8s-ci-robot]

@sbueringer: Closing this issue.

In response to this:

Thx!

/close
all cherry-picks merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.