Document and fixup ownerReferences

[killianmuldoon]

The ownerReference chain in Cluster API provider for vSphere should be consistent with expectations in Kubernetes and Cluster API.

Cluster API has ownerReference guidelines documented at https://cluster-api.sigs.k8s.io/reference/owner_references

Tasks:

• Test to establish the current state. 🌱 Add ownerReference resilience test #2209 started this.
• Document and update tests to assert the expected ownerReference chain in CAPV
• Validate the ownerReference chain to assess whether any need to be fixed, and fix them.
  Consider:
  • Removing the vSphereCluster ownerReference on vSphereMachines. Remove handling of orphaned Machines in reconcileDelete of vspherecluster_controller #2054

[sbueringer]

@killianmuldoon I assume this issue is part of this issue (#2054)? (the last point in your list)

[killianmuldoon]

It's related but not part of the issue IMO - but I've added the cross link where it's relevant.

[sbueringer]

Basically just meant that fixing #2054 would cover "Removing the vSphereCluster ownerReference on vSphereMachines" :)

[killianmuldoon]

/help

The current owner reference chain still needs a once-over once it's documented to ensure it's in line with expectations.

[k8s-ci-robot]

@killianmuldoon:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

The current owner reference chain still needs a once-over once it's documented to ensure it's in line with expectations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.