Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create kube-state-metrics configuration for CRD metrics #2061

Closed
sbueringer opened this issue Jul 20, 2023 · 5 comments · May be fixed by #2310
Closed

Create kube-state-metrics configuration for CRD metrics #2061

sbueringer opened this issue Jul 20, 2023 · 5 comments · May be fixed by #2310
Assignees
@chrischdi
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@sbueringer
Copy link
Member

sbueringer commented Jul 20, 2023 •
edited
Loading

We recently created configuration to expose state metrics for core CAPI CRDs in core CAPI.

We should do the same in CAPV for CRDs for which it makes sense.

Then we should find a pragmatic way how we can use CAPI + CAPV state-metrics via core CAPI tilt up at the same time (currently kube-state-metrics only supports a single metrics config

The generated crd-config of core CAPI can be seen here: https://github.com/kubernetes-sigs/cluster-api/blob/main/hack/observability/kube-state-metrics/crd-config.yaml
@chrischdi chrischdi mentioned this issue Aug 17, 2023
Closed
@sbueringer
Copy link
Member Author

/help

@k8s-ci-robot
Copy link
Contributor

@sbueringer:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 18, 2023
@sbueringer
Copy link
Member Author

/assign @chrischdi

@chrischdi chrischdi mentioned this issue Aug 31, 2023
Open
2 tasks
@chrischdi
Copy link
Member

/close

fixed via #2345

@k8s-ci-robot
Copy link
Contributor

@chrischdi: Closing this issue.

In response to this:

/close

fixed via #2345

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrischdi chrischdi

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
3 participants
@chrischdi @sbueringer @k8s-ci-robot