Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump kustomize to v5 #2886

Open
chrischdi opened this issue Apr 8, 2024 · 6 comments
Open

Bump kustomize to v5 #2886

chrischdi opened this issue Apr 8, 2024 · 6 comments
Assignees
@prashantrewar
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@chrischdi
Copy link
Member

/kind feature

Describe the solution you'd like

CAPI recently bumped kustomize to v5:

We should do the same for CAPV and all kustomize templates we have.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-vsphere version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@chrischdi chrischdi added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Apr 8, 2024
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 8, 2024
@sbueringer
Copy link
Member

cc @adityabhatia If you want to / have time

@prashantrewar
Copy link

Hey @sbueringer and @chrischdi, I'm interested.

@sbueringer
Copy link
Member

Sure. Feel free to go ahead!

/assign @prashantrewar

@prashantrewar
Copy link

Hey @sbueringer, Could you please guide me on this issue. I am new to this project.

Thank you

@sbueringer
Copy link
Member

PTAL at: kubernetes-sigs/cluster-api#10294
We need the same for CAPV

@prashantrewar prashantrewar mentioned this issue Apr 23, 2024
Closed
@chrischdi chrischdi mentioned this issue Jul 5, 2024
Merged
4 tasks
@chrischdi
Copy link
Member Author

xref: #3069 (comment)

Would be nice if we can eventually sync up config folders across CAPI & CAPV once CAPV was migrated to kustomize v5. > Maintaining different variations of all of this is really a pain

(looking at test/extension/config)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prashantrewar prashantrewar

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱Update Kustomize deprecated syntax prashantrewar/cluster-api-provider-vsphere
4 participants
@chrischdi @sbueringer @k8s-ci-robot @prashantrewar