Use generics for functions used in controller-runtime's builders

[chrischdi]

/kind cleanup
/help

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

When using the builder from cotnroller runtime (Setup functions for AddToManager) we should migrate to use generics.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Follow-up from
#3146 (comment)

Environment:

• Cluster-api-provider-vsphere version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

[k8s-ci-robot]

@chrischdi:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/kind cleanup
/help

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

When using the builder from cotnroller runtime (Setup functions for AddToManager) we should migrate to use generics.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Follow-up from
#3146 (comment)

Environment:

• Cluster-api-provider-vsphere version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sbueringer]

Note: It's enough to do this only in cases where we are actually using the types (vs. just using client.Object).

One example would be:

cluster-api-provider-vsphere/controllers/vmware/vspherecluster_reconciler.go

Line 338 in 204790f

vsphereMachine, ok := o.(*vmwarev1.VSphereMachine)

Here we are actually using VSphereMachine, there are also cases where we just use client.Object, in these cases there would be no benefit to moving to generics