-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [release-1.6] Makefile: refactor how govc is built to workaround dependency issues building govc #1983
🐛 [release-1.6] Makefile: refactor how govc is built to workaround dependency issues building govc #1983
Conversation
awesome. We now hit the same issue as on release-1.5 😄 |
/test pull-cluster-api-provider-vsphere-verify-crds |
325a29d
to
2458615
Compare
Note: the follow-up issue gets solved in #1984, which is this one:
|
/retest-required |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The value gets used to run the CI e2e tests. The value in the vsphere-dev.yaml is a placeholder which needs to be updated when running the tests locally. Signed-off-by: Sagar Muchhal <[email protected]>
/test pull-cluster-api-provider-vsphere-verify-gen |
Still needs a lgtm :-) |
/lgtm |
What this PR does / why we need it:
release-1.6
jobs:Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes CI for release-1.6 which is completely red.
Special notes for your reviewer:
Regarding 1.:
github.com/vmware/govmomi
inhack/tools
.hack/tools/go.mod
,govc
(which is part of govmomi) cannot be built anymore because the dependencies refer different versions ofgithub.com/google/uuid
.govmomi
is also not easily possible onrelease-1.6
because this would also bumpgolangci-lint
and result in not being able to buildgovc
too.Because of the above issues and to align with the core CAPI CI tooling, this PR introduces building
govc
in the same version as used in the top levelgo.mod
without usinghack/tools/go.mod
, but thehack/go-install.sh
script instead.Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: