Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [release-1.6] Makefile: refactor how govc is built to workaround dependency issues building govc #1983

Merged

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Jul 11, 2023

What this PR does / why we need it:

  1. Solves issue on release-1.6 jobs:
/home/prow/go/pkg/mod/github.com/vmware/[email protected]/sts/signer.go:38:2: github.com/google/[email protected]: missing go.sum entry for go.mod file; to add it:
	go mod download github.com/google/uuid

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes CI for release-1.6 which is completely red.

Special notes for your reviewer:

Regarding 1.:

  • On release-1.6 we import a very old version of github.com/vmware/govmomi in hack/tools.
  • Together with the other dependencies defined in hack/tools/go.mod, govc (which is part of govmomi) cannot be built anymore because the dependencies refer different versions of github.com/google/uuid.
  • Bumping govmomi is also not easily possible on release-1.6 because this would also bump golangci-lint and result in not being able to build govc too.

Because of the above issues and to align with the core CAPI CI tooling, this PR introduces building govc in the same version as used in the top level go.mod without using hack/tools/go.mod, but the hack/go-install.sh script instead.

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 11, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 11, 2023
@chrischdi
Copy link
Member Author

awesome.

We now hit the same issue as on release-1.5 😄

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-verify-crds

@chrischdi
Copy link
Member Author

Note: the follow-up issue gets solved in #1984, which is this one:


Note: this PR is required to fix CI which is red due to:

Failed to run clusterctl config cluster
Unexpected error:
    <*yamlprocessor.errMissingVariables | 0xc000ccc090>: {
        Missing: [
            "VSPHERE_TLS_THUMBPRINT",
        ],
    }
    value for variables [VSPHERE_TLS_THUMBPRINT] is not set. Please set the value using os environment variables or the clusterctl config file
occurred
/home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/clusterctl/client.go:216}


@chrischdi chrischdi changed the title [WIP] 🌱 Makefile: refactor how govc is built to workaround dependency issues building govc 🌱 Makefile: refactor how govc is built to workaround dependency issues building govc Jul 11, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2023
@chrischdi chrischdi changed the title 🌱 Makefile: refactor how govc is built to workaround dependency issues building govc [release-1.6] 🌱 Makefile: refactor how govc is built to workaround dependency issues building govc Jul 11, 2023
@chrischdi chrischdi changed the title [release-1.6] 🌱 Makefile: refactor how govc is built to workaround dependency issues building govc [release-1.6] 🐛 Makefile: refactor how govc is built to workaround dependency issues building govc Jul 11, 2023
@randomvariable randomvariable changed the title [release-1.6] 🐛 Makefile: refactor how govc is built to workaround dependency issues building govc 🐛 [release-1.6] Makefile: refactor how govc is built to workaround dependency issues building govc Jul 11, 2023
@randomvariable
Copy link
Member

/retest-required
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
The value gets used to run the CI e2e tests. The value in the
vsphere-dev.yaml is a placeholder which needs to be updated when running
the tests locally.

Signed-off-by: Sagar Muchhal <[email protected]>
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-verify-gen

@chrischdi
Copy link
Member Author

Still needs a lgtm :-)

@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 18f9738 into kubernetes-sigs:release-1.6 Jul 11, 2023
4 checks passed
@chrischdi chrischdi deleted the pr-hack-govc-build branch July 11, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants