[release-1.5] 🌱 hack/tools: use go-install.sh for installing controller-gen for 1.5 #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
chrischdi
force-pushed
the
pr-go-install-controller-gen-1-5
branch
from
a28468f
to
3d000f8
Compare
|
/lgtm /assign @randomvariable |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual cherry-pick of #2005
What this PR does / why we need it:
As follow-up of #2004
Adjusts the targets for
controller-gento usehack/go-install.shinstead so we are able to cherry-pick the new version to the release branches of 1.5, 1.6 and 1.7. We do this to makeverify-crdsdeterministic on this branches again.Note: this would not be possible on the release branches by just bumping in
hack/tools/go.modbecause other binaries won't compile then anymore.