-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Only ensure Go minor version #2341
🌱 Only ensure Go minor version #2341
Conversation
Signed-off-by: Stefan Büringer [email protected]
/cherry-pick release-1.8 |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @killianmuldoon @chrischdi @zhanggbj |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2341 +/- ##
==========================================
+ Coverage 50.21% 50.40% +0.18%
==========================================
Files 87 87
Lines 8041 8041
==========================================
+ Hits 4038 4053 +15
+ Misses 3676 3665 -11
+ Partials 327 323 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 1bcab4c0d062b6d6aa00e51594081e696314a4f2
|
/approve /hold feel free to hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@sbueringer: new pull request created: #2343 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Test coverage jobs are broken (https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-vsphere#periodic-test-coverage-main) as kubekins image still contains 1.20.7. I think it's not super important to enforce the patch version.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #