✨ refactor context for vsphereclusteridentity controller

[MrDXY]

What this PR does / why we need it:
Refactor the context in vsphereclusteridentity_controller.go and correct any corresponding function calls. You can discover additional information in reference to #2295.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #2295

[k8s-ci-robot]

Hi @MrDXY. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zhanggbj]

/ok-to-test

[codecov]

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.13% 🎉

Comparison is base (eab5a45) 60.54% compared to head (20640d5) 60.68%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2374      +/-   ##
==========================================
+ Coverage   60.54%   60.68%   +0.13%     
==========================================
  Files         164      164              
  Lines        9464     9464              
==========================================
+ Hits         5730     5743      +13     
+ Misses       3313     3303      -10     
+ Partials      421      418       -3     

Files Changed	Coverage Δ
controllers/vsphereclusteridentity_controller.go	53.84% <83.33%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zhanggbj]

Thanks for the PR!
/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 01d2bc0a4fb4034e4d71306b9958d43225bb2aa0

[zhanggbj]

just a nit, no need to create a new context here https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/controllers/vsphereclusteridentity_controller_test.go#L34C1-L34C1, we already have a ctx in https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/controllers/controllers_suite_test.go#L49

[MrDXY]

just a nit, no need to create a new context here https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/controllers/vsphereclusteridentity_controller_test.go#L34C1-L34C1, we already have a ctx in https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/controllers/controllers_suite_test.go#L49

Sure!

[k8s-ci-robot]

@MrDXY: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-vsphere-apidiff-main	20640d5	link	false	/test pull-cluster-api-provider-vsphere-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[zhanggbj]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 93ce3fe956638af7eb3585b36875e0c4c2e7b6ab

[Ankitasw]

/lgtm

[zhanggbj]

/approve

[zhanggbj]

@chrischdi this is ready for review, please help to take a look :-)

[chrischdi]

/lgtm

[chrischdi]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, zhanggbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chrischdi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment