Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 lint: remove linter ignores from .golangci-lint for gosec #2381

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Removes some exclusions from .golangci.yaml

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #2058

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 25, 2023
@chrischdi chrischdi changed the title lint: remove linter ignores from .golangci-lint 🌱 lint: remove linter ignores from .golangci-lint for gosec Sep 25, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.17% ⚠️

Comparison is base (d37d6f9) 60.96% compared to head (3e16b30) 60.79%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2381      +/-   ##
==========================================
- Coverage   60.96%   60.79%   -0.17%     
==========================================
  Files         164      164              
  Lines        9469     9469              
==========================================
- Hits         5773     5757      -16     
- Misses       3285     3297      +12     
- Partials      411      415       +4     
Files Changed Coverage Δ
...rollers/vspheredeploymentzone_controller_domain.go 47.79% <0.00%> (-8.09%) ⬇️
test/helpers/mod.go 0.00% <0.00%> (ø)
test/helpers/vcsim/builder.go 85.10% <100.00%> (ø)
test/helpers/webhook.go 63.63% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c6b69001a869ac1509847729fadeccb960408168

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 830aa85 into kubernetes-sigs:main Sep 25, 2023
20 of 21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Sep 25, 2023
@chrischdi chrischdi deleted the pr-fix-linter-ignores branch September 25, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants