Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump github.com/vmware/govmomi from 0.30.7 to 0.31.0 #2391

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 25, 2023

Bumps github.com/vmware/govmomi from 0.30.7 to 0.31.0.

Release notes

Sourced from github.com/vmware/govmomi's releases.

v0.31.0

Release v0.31.0

Release Date: 2023-09-25

⚠️ BREAKING

  • [b594bf1f] Move to main

    Changing GoVmomi's default branch from master to main will likely result in dependents needing to repoint their clients and other integrations to the new, default branch.

  • [99200868] Generate JSON tags

    Updating the vim25/types with camelCased, JSON tags affects the output of the govc command when using the -json flag to emit results as JSON. Field names that used to be PascalCased will now be camelCased. Queries for tools that parse JSON, such as jq, will need to be updated to use the new camelCased fields.

    This change was made to support marshaling the eam, pbm, sms, vim, and vslm types to/from JSON using OpenAPI JSON discriminators.

  • [4f9f126a] Change string to *string for Item.Description and Library.Description in library package

    • Test against a VC testbed

      Sending a UpdateLibraryItem request with this change, and set the new description to "". The original item description was "virtualmachinepublishrequest.vmware.com: 6b0d06ad-8e18-4881-a806-2a7c8a7e1b4b", after this UpdateLibraryItem request succeeded, the item description was set to "". While before this change, it would be a no-op for the description.

    • Test using govc

      • Update Library

        Create a library:
        ➜  govmomi git:(issue-3048) ✗ govc library.create -d "description-1" cl-1
        495f611a-cf74-40d6-a54a-8b239cf15406
        ➜  govmomi git:(issue-3048) ✗ ~/go/bin/govc library.info 495f611a-cf74-40d6-a54a-8b239cf15406
        Name:                 cl-1
          ID:                 495f611a-cf74-40d6-a54a-8b239cf15406
          Path:               /cl-1
          Description:        description-1
          Version:            2
          Created:            Fri Feb 17 19:18:22 2023
          Security Policy ID
          StorageBackings:
            DatastoreID:      sharedVmfs-0
            Type:             DATASTORE
        

        Update the library description with new string: ➜ govmomi git:(issue-3048) ✗ ~/go/bin/govc library.update -d "new description" 495f611a-cf74-40d6-a54a-8b239cf15406 ➜ govmomi git:(issue-3048) ✗ ~/go/bin/govc library.info 495f611a-cf74-40d6-a54a-8b239cf15406 Name: cl-1 ID: 495f611a-cf74-40d6-a54a-8b239cf15406

... (truncated)

Commits
  • 2fab8d5 chore: Update version.go for v0.31.0
  • 9d6dca6 Merge pull request #3236 from akutz/feature/8.0U2
  • a03f473 api: Fix errors w 8.0U2 GA update
  • 515df5d api: Update generated types to vSphere 8.0U2 GA
  • b7ceede api: Prep to update types to vSphere 8.0U2 GA
  • c59c149 Merge pull request #3227 from mayankbh/topic/bmayank/guest-datastore-upload-d...
  • 3fb5b82 Use Envoy sidecar for guest and datastore file transfer.
  • 877833c Merge pull request #3228 from vmware/dependabot/github_actions/goreleaser/gor...
  • a83ec3f Merge pull request #3232 from akutz/feature/data-struct-comments
  • cd6389f Merge pull request #3229 from dekp/issue-3050
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps [github.com/vmware/govmomi](https://github.com/vmware/govmomi) from 0.30.7 to 0.31.0.
- [Release notes](https://github.com/vmware/govmomi/releases)
- [Changelog](https://github.com/vmware/govmomi/blob/main/CHANGELOG.md)
- [Commits](vmware/govmomi@v0.30.7...v0.31.0)

---
updated-dependencies:
- dependency-name: github.com/vmware/govmomi
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 25, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 25, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6287964) 60.83% compared to head (a9ed0b9) 60.71%.
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2391      +/-   ##
==========================================
- Coverage   60.83%   60.71%   -0.12%     
==========================================
  Files         164      164              
  Lines        9473     9473              
==========================================
- Hits         5763     5752      -11     
- Misses       3295     3303       +8     
- Partials      415      418       +3     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrischdi
Copy link
Member

@dependabot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-test-main a9ed0b9 link true /test pull-cluster-api-provider-vsphere-test-main
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

 [FAILED] in [It] - /home/prow/go/pkg/mod/github.com/onsi/ginkgo/[email protected]/internal/suite.go:865 @ 09/25/23 20:56:09.138
  STEP: Destroying integration test namespace @ 09/25/23 20:56:09.141
  STEP: Shutting down guest cluster control plane @ 09/25/23 20:56:09.144
  << Timeline
  [FAILED] Timed out after 1.042s.
  Expected success, but got an error:
      <*errors.StatusError | 0xc0002fc3c0>: 
      services "supervisor" not found
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "services \"supervisor\" not found",
              Reason: "NotFound",
              Details: {Name: "supervisor", Group: "", Kind: "services", UID: "", Causes: nil, RetryAfterSeconds: 0},
              Code: 404,
          },
      }
  In [It] at: /home/prow/go/pkg/mod/github.com/onsi/ginkgo/[email protected]/internal/suite.go:865 @ 09/25/23 20:56:09.138

/retest

@killianmuldoon
Copy link
Contributor

/retest

@chrischdi
Copy link
Member

let's do one more round

/retest

@killianmuldoon
Copy link
Contributor

let's do one more round

/retest

This doesn't work - need to retrigger it manually.

@chrischdi
Copy link
Member

/test help

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-conformance-main
  • /test pull-cluster-api-provider-vsphere-e2e-full-main
  • /test pull-cluster-api-provider-vsphere-e2e-main
  • /test pull-cluster-api-provider-vsphere-test-integration-main
  • /test pull-cluster-api-provider-vsphere-test-main
  • /test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-main
  • pull-cluster-api-provider-vsphere-e2e-main
  • pull-cluster-api-provider-vsphere-test-integration-main
  • pull-cluster-api-provider-vsphere-test-main
  • pull-cluster-api-provider-vsphere-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member

/test pull-cluster-api-provider-vsphere-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-full-main
/test pull-cluster-api-provider-vsphere-e2e-main
/test pull-cluster-api-provider-vsphere-test-integration-main
/test pull-cluster-api-provider-vsphere-test-main

@chrischdi
Copy link
Member

meanwhile there is 0.32.0 out :D

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 60be21d8a6955a63906e70a097868d89851705e9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit 276d85c into main Sep 29, 2023
23 of 24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Sep 29, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/vmware/govmomi-0.31.0 branch September 29, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants