🐛 Remove the conditional on ipv6

[ekarlso]

Signed-off-by: ekarlso [email protected]

What this PR does / why we need it:

Edit: This allows to use IPAM together with ipv4 ippools which do not define a gateway (special airgapped scenario).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2396

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: ekarlso / name: Endre Karlson (43bf20b)

[k8s-ci-robot]

Welcome @ekarlso!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ekarlso. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zhanggbj]

Thanks for the PR!
Just one nit, as we want to make Gateway optional for both IPv4 and IPv6, could you please also update the comment in L55 to make it consistent. Thanks!

[zhanggbj]

/ok-to-test

[zhanggbj]

Hi @ekarlso, please also sign the CLA, you could follow the guide above :-)

[chrischdi]

This is for #2396

[killianmuldoon]

/retitle 🐛 Remove the conditional on ipv6

[chrischdi]

This PR also needs to fix the relevant tests :-)

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ed46a47) 60.87% compared to head (43bf20b) 61.07%.
Report is 27 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2397      +/-   ##
==========================================
+ Coverage   60.87%   61.07%   +0.19%     
==========================================
  Files         164      163       -1     
  Lines        9473     9435      -38     
==========================================
- Hits         5767     5762       -5     
+ Misses       3293     3261      -32     
+ Partials      413      412       -1     

Files	Coverage Δ
pkg/services/govmomi/ipam/parse.go	100.00% <100.00%> (ø)

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chrischdi]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 0f6c990845677f45f0237b382d899c41b1fa957c

[killianmuldoon]

Thanks!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [killianmuldoon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[killianmuldoon]

Should we backport this to 1.8 / 1.7?

[chrischdi]

Should we backport this to 1.8 / 1.7?

I was thinking about that too. Would make sense to me to do so. It reduces the restrictions on the field so it should be okay?!

[killianmuldoon]

/cherry-pick release-1.8

[killianmuldoon]

/cherry-pick release-1.7

[killianmuldoon]

Yeah - absolutely fine with backporting this as a bug.

[k8s-infra-cherrypick-robot]

@killianmuldoon: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@killianmuldoon: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

/cherry-pick release-1.7

[k8s-infra-cherrypick-robot]

@killianmuldoon: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

@chrischdi - looks like we might have an issue with the cherrypick bot 🤔

I've opened an issue over at test infra (kubernetes/test-infra#30937)

[killianmuldoon]

/cherry-pick release-1.7

[killianmuldoon]

/cherry-pick release-1.8

[k8s-infra-cherrypick-robot]

@killianmuldoon: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@killianmuldoon: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chrischdi]

/cherry-pick release-1.8

[k8s-infra-cherrypick-robot]

@chrischdi: new pull request created: #2424

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chrischdi]

/cherry-pick release-1.7

[k8s-infra-cherrypick-robot]

@chrischdi: new pull request created: #2425

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.