🌱 Remove nolint for gosec #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2406 +/- ##
==========================================
+ Coverage 60.74% 60.89% +0.14%
==========================================
Files 164 164
Lines 9475 9475
==========================================
+ Hits 5756 5770 +14
+ Misses 3302 3291 -11
+ Partials 417 414 -3
☔ View full report in Codecov by Sentry. |
Ankitasw
force-pushed
the
remove-nolint-gosec
branch
from
d1ef3b7
to
73e3e5c
Compare
Ankitasw
force-pushed
the
remove-nolint-gosec
branch
from
73e3e5c
to
66126e9
Compare
k8s-ci-robot
added
size/XS
Ankitasw
force-pushed
the
remove-nolint-gosec
branch
from
66126e9
to
c5c1dba
Compare
Ankitasw
force-pushed
the
remove-nolint-gosec
branch
from
c5c1dba
to
aa1c75e
Compare
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 836457a07f91f3c01b77bbf9c7b2eb1a36411b95
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove
//nolint:goseclinter usage and provided comments for the usages where it's kept as is. Mainly, usage in tests are kept as is.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #2384