Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Remove v1alpha3 and v1alpha4 #2414

Merged
merged 1 commit into from
Oct 13, 2023
Merged

⚠️ Remove v1alpha3 and v1alpha4 #2414

merged 1 commit into from
Oct 13, 2023

Conversation

killianmuldoon
Copy link
Contributor

Remove the api types and related tooling related to the v1alpha3 and v1alpha4 apiVersions.

Fixes #2165

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 4, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 4, 2023
@killianmuldoon killianmuldoon mentioned this pull request Oct 4, 2023
Closed
6 tasks
killianmuldoon
killianmuldoon commented Oct 4, 2023
View reviewed changes
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

To broadcast in the community a bit more.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebba8af) 60.93% compared to head (b04714a) 62.81%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2414      +/-   ##
==========================================
+ Coverage   60.93%   62.81%   +1.88%     
==========================================
  Files         163      122      -41     
  Lines        9428     8770     -658     
==========================================
- Hits         5745     5509     -236     
+ Misses       3266     2867     -399     
+ Partials      417      394      -23
Files Coverage Δ
pkg/manager/manager.go 84.61% <ø> (-0.39%) ⬇️
pkg/services/vmoperator/vmopmachine.go 73.68% <100.00%> (+4.83%) ⬆️
test/helpers/envtest.go 72.59% <ø> (-0.41%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@killianmuldoon
Copy link
Contributor Author

/test

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-conformance-main
  • /test pull-cluster-api-provider-vsphere-e2e-full-main
  • /test pull-cluster-api-provider-vsphere-e2e-main
  • /test pull-cluster-api-provider-vsphere-test-integration-main
  • /test pull-cluster-api-provider-vsphere-test-main
  • /test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-main
  • pull-cluster-api-provider-vsphere-e2e-main
  • pull-cluster-api-provider-vsphere-test-integration-main
  • pull-cluster-api-provider-vsphere-test-main
  • pull-cluster-api-provider-vsphere-verify-main

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@killianmuldoon killianmuldoon force-pushed the pr-remove-alpha3-alpha4 branch 2 times, most recently from c614888 to a314a30 Compare October 4, 2023 11:40
@killianmuldoon killianmuldoon changed the title [WIP] ⚠️ Remove v1alpha3 and v1alpha4 ⚠️ Remove v1alpha3 and v1alpha4 Oct 4, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 4, 2023
@killianmuldoon
Remove v1alpha3 and v1alpha4
b04714a 
Signed-off-by: killianmuldoon <[email protected]>
@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@killianmuldoon
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2023
@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-apidiff-main b04714a link false /test pull-cluster-api-provider-vsphere-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrischdi
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 468b78b93092f2568dbaac749a5b5a5b04e2332b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrischdi
Copy link
Member

/hold
so you can unhold @killianmuldoon

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 13, 2023
@chrischdi
Copy link
Member

Retriggered the codecov job... flaky unit/integration tests ...

@killianmuldoon
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit a1db12e into kubernetes-sigs:main Oct 13, 2023
18 of 19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxRink MaxRink Awaiting requested review from MaxRink

@srm09 srm09 Awaiting requested review from srm09

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

Removing v1alpha3 & v1alpha4 apiVersions
3 participants
@killianmuldoon @k8s-ci-robot @chrischdi