Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove context from capv customized controller context #2431

Merged
merged 1 commit into from
Oct 25, 2023

Remove context from capv customized controller context

fa689e1
Select commit
Loading
Failed to load commit list.
Merged

🌱 Remove context from capv customized controller context #2431

Remove context from capv customized controller context
fa689e1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 25, 2023 in 1s

62.69% (+0.03%) compared to 013ce3f

View this Pull Request on Codecov

62.69% (+0.03%) compared to 013ce3f

Details

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (013ce3f) 62.65% compared to head (fa689e1) 62.69%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2431      +/-   ##
==========================================
+ Coverage   62.65%   62.69%   +0.03%     
==========================================
  Files         122      122              
  Lines        8770     8763       -7     
==========================================
- Hits         5495     5494       -1     
+ Misses       2877     2872       -5     
+ Partials      398      397       -1     
Files Coverage Δ
controllers/vspherevm_controller.go 63.76% <100.00%> (ø)
pkg/clustermodule/util.go 100.00% <100.00%> (ø)
pkg/context/controller_manager_context.go 75.00% <ø> (ø)
pkg/context/fake/fake_controller_context.go 100.00% <100.00%> (ø)
...kg/context/fake/fake_controller_manager_context.go 100.00% <ø> (ø)
pkg/context/vm_context.go 100.00% <100.00%> (ø)
pkg/context/vspheredeploymentzone_context.go 84.61% <100.00%> (ø)
pkg/manager/manager.go 84.41% <100.00%> (-0.20%) ⬇️
pkg/services/govmomi/cluster/service.go 78.57% <ø> (ø)
pkg/services/govmomi/context.go 0.00% <ø> (ø)
... and 11 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.