🌱 Bump Makefile dependency versions

[killianmuldoon]

Bump dependencies for:

• envtest
• gotestsum
• conversion-gen
• yq
• govulncheck

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (442524b) 62.95% compared to head (c0bbde7) 62.75%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2445      +/-   ##
==========================================
- Coverage   62.95%   62.75%   -0.20%     
==========================================
  Files         122      122              
  Lines        8770     8770              
==========================================
- Hits         5521     5504      -17     
- Misses       2858     2871      +13     
- Partials      391      395       +4     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chrischdi]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 5a268322da98ef4f255d7dca948320c6759b6be9

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chrischdi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[MrDXY]

Hi, @killianmuldoon, I found the make test could fail on the master branch(locally executed on mac, not sure if this is only my case). But if I change the
export KUBEBUILDER_ENVTEST_KUBERNETES_VERSION ?= 1.28.0 to
export KUBEBUILDER_ENVTEST_KUBERNETES_VERSION ?= 1.27.1
the test passes.

Also, the error message indicates: unable to start control plane itself: failed to start the controlplane. retried 5 times: exec: "etcd": executable file not found in $PATH.

Would you mind taking a quick look? Or maybe I should check my environment setup.

[killianmuldoon]

@MrDXY thanks for catching that - I have the version set outside my environment locally.

Can you see if the changes in #2446 fix the issue for you?

[MrDXY]

I re-run make test locally, but the error persists. Also, I found a stack trace which may help resolve it. And I will double-check my environment settings tomorrow. Hope I didn't get you in the wrong direction.

------------------------------
[SynchronizedBeforeSuite] [FAILED] [0.008 seconds]
[SynchronizedBeforeSuite] 
/Users/dxinyuan/MrDXY/cluster-api-provider-vsphere/pkg/identity/identity_suite_test.go:74

  Timeline >>
  STEP: Creating new test environment @ 10/18/23 21:20:33.248
  [FAILED] in [SynchronizedBeforeSuite] - /Users/dxinyuan/MrDXY/cluster-api-provider-vsphere/pkg/identity/identity_suite_test.go:79 @ 10/18/23 21:20:33.256
  << Timeline

  [FAILED] Unexpected error:
      <*fmt.wrapError | 0x1400031f3c0>: 
      unable to start control plane itself: failed to start the controlplane. retried 5 times: exec: "etcd": executable file not found in $PATH
      {
          msg: "unable to start control plane itself: failed to start the controlplane. retried 5 times: exec: \"etcd\": executable file not found in $PATH",
          err: <*fmt.wrapError | 0x1400031f3a0>{
              msg: "failed to start the controlplane. retried 5 times: exec: \"etcd\": executable file not found in $PATH",
              err: <*exec.Error | 0x1400031f360>{
                  Name: "etcd",
                  Err: <*errors.errorString | 0x1400010a3e0>{
                      s: "executable file not found in $PATH",
                  },
              },
          },
      }
  occurred
  In [SynchronizedBeforeSuite] at: /Users/dxinyuan/MrDXY/cluster-api-provider-vsphere/pkg/identity/identity_suite_test.go:79 @ 10/18/23 21:20:33.256
------------------------------

[killianmuldoon]

Would be good to see what comes up as the command when you run make test let's maybe continue this conversation in slack though 😅 could you open a thread when you come back around to this?