-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Clarify our goals for CAPV releases related to CAPI, CPI and Kubernetes releases #2620
🌱 Clarify our goals for CAPV releases related to CAPI, CPI and Kubernetes releases #2620
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2620 +/- ##
==========================================
- Coverage 64.81% 64.80% -0.02%
==========================================
Files 118 118
Lines 8580 8580
==========================================
- Hits 5561 5560 -1
- Misses 2590 2591 +1
Partials 429 429 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to formalize those practices/policies!
Just nits from my side
releases Signed-off-by: Stefan Büringer [email protected]
2c5da8f
to
aab90fa
Compare
Thx for the review, fixed |
/lgtm |
LGTM label has been added. Git tree hash: 8367a754a5edfb66cb162e08afed8ebce2b25094
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: srm09 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #