Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Rename e2e-image #2652

Merged
merged 1 commit into from
Jan 26, 2024
Merged

🌱 Rename e2e-image #2652

merged 1 commit into from
Jan 26, 2024

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
Just renaming the image we use in e2e tests to be ~ consistent how we do it in CAPI.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 23, 2024
@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 23, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4e07cd) 64.52% compared to head (a825163) 64.86%.
Report is 16 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2652      +/-   ##
==========================================
+ Coverage   64.52%   64.86%   +0.33%     
==========================================
  Files         118      118              
  Lines        8580     8580              
==========================================
+ Hits         5536     5565      +29     
+ Misses       2608     2587      -21     
+ Partials      436      428       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbueringer
Copy link
Member Author

(I'll look into the errors :))

@fabriziopandini
Copy link
Member

lgtm pending ci fix

@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@sbueringer
Rename e2e-image
a825163 
Signed-off-by: Stefan Büringer [email protected]
@sbueringer sbueringer force-pushed the pr-rename-e2e-image branch 2 times, most recently from d9fcb28 to a825163 Compare January 25, 2024 17:02
@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@sbueringer
Copy link
Member Author

@fabriziopandini should be okay now

@chrischdi
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@sbueringer
Copy link
Member Author

/assign @fabriziopandini

chrischdi
chrischdi reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7f5c1a92ce5c234258bed0bd1555f61893e9b7e6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ba8b131 into kubernetes-sigs:main Jan 26, 2024
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Jan 26, 2024
@sbueringer sbueringer deleted the pr-rename-e2e-image branch January 29, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@yastij yastij Awaiting requested review from yastij

@zhanggbj zhanggbj Awaiting requested review from zhanggbj

Assignees

@chrischdi chrischdi

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @fabriziopandini @chrischdi @k8s-ci-robot