Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add laozc to CAPV reviewer #2654

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

laozc
Copy link
Member

@laozc laozc commented Jan 24, 2024

What this PR does / why we need it:
This PR adds myself (@laozc) to the CAPV reviewer list.

I've been contributing to CAPV project since July 2023.
I made a few changes with some feature and bug fixes.
I would like to continue with that in future with a new role as a reviewer to help the project.

PRs: https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pulls?q=is%3Apr+is%3Aclosed+author%3Alaozc
Issues: https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/issues?q=is%3Aissue+is%3Aclosed+author%3Alaozc

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 24, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3559ab2) 64.46% compared to head (ba3f22c) 64.82%.
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2654      +/-   ##
==========================================
+ Coverage   64.46%   64.82%   +0.36%     
==========================================
  Files         118      118              
  Lines        8580     8580              
==========================================
+ Hits         5531     5562      +31     
+ Misses       2612     2589      -23     
+ Partials      437      429       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrischdi
Copy link
Member

Happy to have you here 🎉 and thanks for all the work!

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
@sbueringer
Copy link
Member

Thx for all your contributions and welcome as reviewer :)

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4687182b1eca23354eccf27af937676003a99755

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chrischdi,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b230286 into kubernetes-sigs:main Jan 24, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Jan 24, 2024
@fabriziopandini
Copy link
Member

Welcome and congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants