🌱 Improve patch helper error handling #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/M
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2865 +/- ##
==========================================
- Coverage 63.97% 63.95% -0.03%
==========================================
Files 160 160
Lines 9375 9367 -8
==========================================
- Hits 5998 5991 -7
+ Misses 2917 2915 -2
- Partials 460 461 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gong Zhang <[email protected]>
zhanggbj
force-pushed
the
improve_patch_helper
branch
from
23c54aa
to
8b9dad1
Compare
zhanggbj
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
chrischdi
reviewed
Apr 2, 2024
chrischdi
reviewed
Apr 2, 2024
|
/approve |
k8s-ci-robot
added
the
approved
|
/assign sbueringer |
|
Thx! Nice cleanup /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 15dc658067449ca05fb3e170ac5c8796b9fc0f23
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Improve patch helper error handling, as the patch package has improved to contain related context here.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #2549