From 2145ed10aadd5690d1b7d83ee028040adeaf2470 Mon Sep 17 00:00:00 2001 From: Christian Schlotter Date: Wed, 21 Feb 2024 11:31:05 +0100 Subject: [PATCH 1/2] docs: document tagging the test go module --- docs/release/release-tasks.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/release/release-tasks.md b/docs/release/release-tasks.md index 853ad95b07..c584ee7158 100644 --- a/docs/release/release-tasks.md +++ b/docs/release/release-tasks.md @@ -122,12 +122,15 @@ From this point forward changes which should land in the release have to be cher # Export the tag of the release to be cut, e.g.: export RELEASE_TAG=v1.8.0-beta.0 # Create tags locally - # Warning: The test tag MUST NOT be an annotated tag. git tag -s -a ${RELEASE_TAG} -m ${RELEASE_TAG} + # Warning: The test tag MUST NOT be an annotated tag. + # Warning: only for >= release-1.9 + git tag -s test/${RELEASE_TAG} # Push tags # Note: `upstream` must be the remote pointing to `github.com/kubernetes-sigs/cluster-api-provider-vsphere`. git push upstream ${RELEASE_TAG} + git push upstream test/${RELEASE_TAG} ``` This will automatically trigger: From 09486f7a295a5ba3375610323dc68a69007e7c5a Mon Sep 17 00:00:00 2001 From: Christian Schlotter Date: Fri, 5 Apr 2024 16:08:01 +0200 Subject: [PATCH 2/2] do not sign test tag --- docs/release/release-tasks.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/release/release-tasks.md b/docs/release/release-tasks.md index c584ee7158..4d2dedf5c8 100644 --- a/docs/release/release-tasks.md +++ b/docs/release/release-tasks.md @@ -125,7 +125,7 @@ From this point forward changes which should land in the release have to be cher git tag -s -a ${RELEASE_TAG} -m ${RELEASE_TAG} # Warning: The test tag MUST NOT be an annotated tag. # Warning: only for >= release-1.9 - git tag -s test/${RELEASE_TAG} + git tag test/${RELEASE_TAG} # Push tags # Note: `upstream` must be the remote pointing to `github.com/kubernetes-sigs/cluster-api-provider-vsphere`.