Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Use setup-envtest from CR main (05/2024) to use envtest binaries from CT releases #3016

Merged
merged 1 commit into from
May 23, 2024

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented May 22, 2024

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
See kubernetes-sigs/cluster-api#10569 for context

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2024
@sbueringer
Copy link
Member Author

Not a new flake, but independent

/retest

@sbueringer
Copy link
Member Author

/retest

(this test is also failing too often on main recently, I'll take a look soon)

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2024
@sbueringer sbueringer force-pushed the pr-envtest-main branch 2 times, most recently from 68c5302 to 2746d6b Compare May 23, 2024 08:44
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 23, 2024
@sbueringer
Copy link
Member Author

tests will be fixed in #3021

@fabriziopandini
Copy link
Member

/test pull-cluster-api-provider-vsphere-test-main

@sbueringer
Copy link
Member Author

sbueringer commented May 23, 2024

tests will be fixed in #3021

@fabriziopandini ^^

(Although there's a small chance they become green :D)

EDIT: looks like we got lucky :)

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 31881d656c8e81534c13c089a1d8b3f8bfa57e01

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit 88627bd into kubernetes-sigs:main May 23, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants