🌱 packaging: write kubeadm script log for ignition #3149
Conversation
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
size/M
|
/test help |
|
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main |
sbueringer
force-pushed
the
pr-ignition-add-and-collect-logfile
branch
from
a2fd6ae
to
43ffbe8
Compare
k8s-ci-robot
added
size/S
| @@ -96,6 +96,8 @@ func (c *MachineLogCollector) CollectMachineLog(ctx context.Context, ctrlClient | |||
| "sudo", "cat", "/var/log/cloud-init.log"), | |||
| captureLogs("cloud-init-output.log", | |||
| "sudo", "cat", "/var/log/cloud-init-output.log"), | |||
| captureLogs("kubeadm-service.log", | |||
There was a problem hiding this comment.
I assume this doesn't fail the test because we only bubble up the error to a certain point, but we don't fail the test because of that
(also the reason why the cloud-init files above don't lead to a failure of the ignition test)
There was a problem hiding this comment.
Exact, it does not fail on errors, just logs it.
|
Feel free to merge once tests are green /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c4b2a4324fd7f99866d2a14286fb780656b13770
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@chrischdi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
What this PR does / why we need it:
Debatable if we want to have this. It was handy for debugging. Cloud-init does it simiarily.
/hold
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #