✨ add function to remove VSphere VM object from VM Group

[abhinandanbaheti]

What this PR does / why we need it:

This PR adds a function to remove VSphere VM object from VM Group

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: abhinandanbaheti / name: Abhinandan Baheti (86d8ee7)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gab-satchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @abhinandanbaheti. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[abhinandanbaheti]

/easycla

[sbueringer]

Why are we adding a function that we are seemingly not using?

[abhinandanbaheti]

Why are we adding a function that we are seemingly not using?

@sbueringer

I have a use case where I need to add / remove VM's to/from VM Group through Golang API, andI didn't find a direct way to for these in the govmomi, and then found this suggestion in the (vmware/govmomi#3033 (comment)) to use CAPV. It has wrapper method to add VM in VM Group, check if VM Group exists, but doesn't have method to remove the VM from VM Group. Therefore, I have added this PR.

[sbueringer]

@abhinandanbaheti

I think Doug is not suggesting to use CAPV as a library
He's just saying that in the CAPV code there "is a good example of adding VMs to a group"

I would highly recommend not depending on CAPV as a library to communicate with vSphere, because it is not a library
We only implement what we use in CAPV and there are absolutely no guarantees that anything stays stable for consumers of CAPV Go code (or even that it stays exported/public)

You also get a huge amount of Go dependencies and coupling to use exactly the same Go dependencies as CAPV if you use us as a library (e.g. controller-runtime, Cluster API, ...)

[sbueringer]

Closing this for now ^^ (also talked about it with @abhinandanbaheti)

/close

[k8s-ci-robot]

@sbueringer: Closed this PR.

In response to this:

Closing this for now ^^ (also talked about this with @abhinandanbaheti)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.