-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 KCP: propagate timeouts to Machines with deletionTimestamp #11128
🌱 KCP: propagate timeouts to Machines with deletionTimestamp #11128
Conversation
/assign @chrischdi @fabriziopandini @enxebre |
/test pull-cluster-api-e2e-conformance-ci-latest-main |
Signed-off-by: Stefan Büringer [email protected]
dc87a0a
to
f0d197a
Compare
/test pull-cluster-api-e2e-conformance-ci-latest-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: d0714afd76f4de3f68d9bdbd587b75dab5eb5423
|
/assign @chrischdi |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer @chrischdi @enxebre what about back porting to 1.8? |
No strong opinion. Our timeout propagation story is not very complete today. There are plenty of places where we don't propagate enough to make something like Cluster.spec.topology => KCP / (MD => MS) => Machine work But yeah this PR is one step in the right direction |
Fine to keep it in main only. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Noticed when implementing #11127 that KCP does not propagate timeouts to deleting Machines. This was recently implemented for MachineSets. This PR implements it for KCP as well
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #