Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart 'kind' reference confuses ArgoCD #1556

Open
kenlasko opened this issue Nov 16, 2024 · 1 comment
Open

Helm chart 'kind' reference confuses ArgoCD #1556

kenlasko opened this issue Nov 16, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@kenlasko
Copy link

What version of descheduler are you using?

descheduler version: 0.31.0

Does this issue reproduce with the latest release?
Yes

Which descheduler CLI options are you using?
N/A

Please provide a copy of your descheduler policy config file
Via values.yaml:

# kind: Deployment
schedule: "30 */2 * * *"  # Every hour at 30 min past
priorityClassName: high-priority
deschedulerPolicy:
  nodeSelector: "storage=longhorn"
  strategies:
    RemoveDuplicates:
      enabled: true
    RemovePodsHavingTooManyRestarts:
      enabled: true
      params:
        podsHavingTooManyRestarts:
          podRestartThreshold: 10
          includingInitContainers: true
    RemovePodsViolatingNodeTaints:
      enabled: true
    RemovePodsViolatingNodeAffinity:
      enabled: true
      params:
        nodeAffinityType:
        - requiredDuringSchedulingIgnoredDuringExecution
    RemovePodsViolatingInterPodAntiAffinity:
      enabled: true 
    RemovePodsViolatingTopologySpreadConstraint:
      enabled: false
      params:
        includeSoftConstraints: false
    LowNodeUtilization:
      enabled: true 
      params:
        priorityThreshold:
          name: "medium-priority"
        nodeResourceUtilizationThresholds:
          thresholds:
            cpu: 100
            memory: 100
            pods: 20
          targetThresholds:
            cpu: 100
            memory: 100
            pods: 33

What k8s version are you using (kubectl version)?
1.31.2

What did you do?
When attempting to change from using CronJob to Deployment for Descheduler, the kind: Deployment reference in the values.yaml makes ArgoCD think it is a manifest and throws the error: groupVersion shouldn't be empty

Simplest fix would be to change the kind reference to something else to avoid the confusion. I suggest something like appKind or something similar.

@kenlasko kenlasko added the kind/bug Categorizes issue or PR as related to a bug. label Nov 16, 2024
@echozio
Copy link

echozio commented Nov 28, 2024

I would think this would be better dealt with by either putting values.yaml somewhere where ArgoCD doesn't look for manifests to deploy or by setting an include or exclude pattern on the responsible application's directory source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants