Using the txtSuffix field in the helm chart does nothing

[jmtx1020]

What happened:

I set the txtSuffix and txtPrefix but only the txtSuffix shows up when I render the YAML.

What you expected to happen:
I would expect both to show.

How to reproduce it (as minimally and precisely as possible):

values.yaml:

  provider:
    name: cloudflare
  env:
    - name: CF_API_TOKEN
      valueFrom:
        secretKeyRef:
          name: external-cf-secrets
          key: CF_API_TOKEN
  txtPrefix: "test-prefix"
  txtSuffix: "test-suffix"
  txtOwnerId: "testing"

relevant lines from the deployment.yaml:

          args:
            - --log-level=info
            - --log-format=text
            - --interval=1m
            - --source=service
            - --source=ingress
            - --policy=upsert-only
            - --registry=txt
            - --txt-owner-id=testing
            - --txt-prefix=test-prefix
            - --provider=cloudflare

Anything else we need to know?:
Using the latest version of the helm chart 1.14.5,
Environment:

• External-DNS version (use external-dns --version): v0.14.2
• DNS provider: cloudflare, ns1

[jmtx1020]

Update, I reviewed the code for the helm chart here:

            {{- if and (eq .Values.txtPrefix "") (ne .Values.txtSuffix "") }}
            - --txt-suffix={{ .Values.txtSuffix }}
            {{- end }}

It will work if I set txtPrefix: "" but not if its not set. If this is intended we can close this issue but this seems strange to me since both values default to nil

[kundan2707]

@jmtx1020 it mentioned in its description that txtSuffix and txtSuffix are mutually exclusive.
so it seems correct

[jmtx1020]

Hey @kundan2707 ,

We can close this issue if it's meant to work that way but it seemed weird to have to set something to "" to make the other work.