Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacements IgnoreMissingField #5777

Open
2 tasks done
bt-macole opened this issue Oct 3, 2024 · 1 comment · May be fixed by #5778
Open
2 tasks done

Replacements IgnoreMissingField #5777

bt-macole opened this issue Oct 3, 2024 · 1 comment · May be fixed by #5778
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@bt-macole
Copy link

bt-macole commented Oct 3, 2024

Eschewed features

  • This issue is not requesting templating, unstuctured edits, build-time side-effects from args or env vars, or any other eschewed feature.

What would you like to have added?

include in FieldOptions a bool for IgnoreMissingField in order to apply replacements across many files, ignoring those, that don't have the field.

Why is this needed?

When using replacements as a reusable component across multiple manifests, especially in environmental overlays, a common pattern emerges. For example, certain elements like an accountId in an IRSA role annotation on a ServiceAccount often need to be replaced.

In cases where you have many ServiceAccount resources—such as N applications with M workloads and M ServiceAccounts—only X of those ServiceAccounts may require the annotation replacement, while others do not.

This approach ensures flexibility, allowing replacements to be applied only where needed, without enforcing unnecessary changes across all resources.

Can you accomplish the motivating task without this feature, and if so, how?

The task can be accomplished, but it requires more granular use of the replacement, targeting specific ServiceAccounts which can result in more complexity, code duplication, and errors.

What other solutions have you considered?

Pattern matching with regex on the target name so the replacement only applies to resources that match a specific name format.

Anything else we should know?

No response

Feature ownership

  • I am interested in contributing this feature myself! 🎉
@bt-macole bt-macole added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 3, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 3, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants