Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI driver logs passowrd in cleartext whith DEBUg loglevel #3089

Open
MaxRink opened this issue Oct 24, 2024 · 1 comment
Open

CSI driver logs passowrd in cleartext whith DEBUg loglevel #3089

MaxRink opened this issue Oct 24, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@MaxRink
Copy link

MaxRink commented Oct 24, 2024

/kind bug

What happened:
We turned on DEBUG logs for debugging and found the the password used by the CSI driver gets logged in full.
2024-10-24T15:10:04.861Z DEBUG config/config.go:422 vc server my.server config: &{User:myuser Password:mypwd VCenterPort:443 InsecureFlag:true Datacenters:REF TargetvSANFileShareDatastoreURLs: TargetvSANFileShareClusters: MigrationDataStoreURL:}{"TraceId": "ea031f5d-8bf6-47ba-b939-698b31aae0cc"}
What you expected to happen:
Passwords get redacted in log output

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • csi-vsphere version: 3.3.1
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 24, 2024
@divyenpatel
Copy link
Member

@MaxRink issue is fixed with this PR - #3063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants