fix: reduce test cases and memory for image benchmark #17385
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run this benchmark in minikube's github action, some problems occurred. See GoogleContainerTools/minikube-image-benchmark#40
To solve this problem, a PR has been created for minikube-image-benchmark adding some feature to solve the problems.
and, according to the changes introduced by that PR, some small changes also need to be added to minikube's github action, so that we can use the new features
The Before-After comparasion:
After: https://github.com/ComradeProgrammer/minikube/actions/runs/6495925502/job/17641822215
This is a test run on github action. This time image-benchmark can be executed correctly on github action instance.
(The status of this action is still error, it is because of the aws s3 command, from the log you can see the image-benchmark execution was successful)