Release Notes Collection Picks Up Incorrect Text #3516

npolshakova · 2024-03-18T19:19:21Z

What happened:

Release notes collection automation has resulted in incorrect text and markdown being collected: kubernetes/sig-release#2449 (comment)

You can see examples of this merged in sig-release for 1.30 due to past release notes collection:

Updated examples from 1.29 that are still in the repo after 1.30 was cleaned up:

Fix stale conntrack flow detection logic kubernetes#119394, release notes here.

What you expected to happen:

This release note should not be collected since it is empty:

 "123082": {
    "commit": "d29f38efd83f5dcf18870c8772b9a0bb68c56097",
    "text": "```\n\n#### Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:\n\n\u003c!--\nThis section can be blank if this pull request does not require a release note.\n\nWhen adding links which point to resources within git repositories, like\nKEPs or supporting documentation, please reference a specific commit and avoid\nlinking directly to the master branch. This ensures that links reference a\nspecific point in time, rather than a document that may change over time.\n\nSee here for guidance on getting permanent links to files: https://help.github.com/en/articles/getting-permanent-links-to-files\n\nPlease use the following format for linking documentation:\n- [KEP]: \u003clink\u003e\n- [Usage]: \u003clink\u003e\n- [Other doc]: \u003clink\u003e\n--\u003e",
    "markdown": "```\n  \n  #### Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:\n  \n  \u003c!--\n  This section can be blank if this pull request does not require a release note.\n  \n  When adding links which point to resources within git repositories, like\n  KEPs or supporting documentation, please reference a specific commit and avoid\n  linking directly to the master branch. This ensures that links reference a\n  specific point in time, rather than a document that may change over time.\n  \n  See here for guidance on getting permanent links to files: https://help.github.com/en/articles/getting-permanent-links-to-files\n  \n  Please use the following format for linking documentation:\n  - [KEP]: \u003clink\u003e\n  - [Usage]: \u003clink\u003e\n  - [Other doc]: \u003clink\u003e\n  --\u003e ([#123082](https://github.com/kubernetes/kubernetes/pull/123082), [@alexzielenski](https://github.com/alexzielenski)) [SIG API Machinery and Testing]",
    "author": "alexzielenski",
    "author_url": "https://github.com/alexzielenski",
    "pr_url": "https://github.com/kubernetes/kubernetes/pull/123082",
    "pr_number": 123082,
    "areas": [
      "test"
    ],
    "kinds": [
      "flake"
    ],
    "sigs": [
      "api-machinery",
      "testing"
    ],
    "duplicate": true,
    "do_not_publish": true
  },

The text was updated successfully, but these errors were encountered:

saschagrunert · 2024-03-19T07:35:27Z

@npolshakova thank you for the bug report, are you considering to work on a fix?

npolshakova · 2024-03-19T13:52:21Z

@npolshakova thank you for the bug report, are you considering to work on a fix?

I'd be interested, but I'm not super familiar with the code that does the release notes collection. Do you think this is an issue on the krel side here?

saschagrunert · 2024-03-21T11:36:20Z

@npolshakova I assume it's part of the release notes gathering logic of this repository. We just need a reproducer to see what we can fix.

npolshakova · 2024-03-27T17:46:58Z

I think the issue is in the regex in the exclude filter: https://github.com/kubernetes/release/pull/3523/files I'm able to reproduce it, but still need a fix for the regex.

k8s-triage-robot · 2024-06-25T18:08:33Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

saschagrunert · 2024-06-27T07:34:41Z

@npolshakova are you still working on this?

/remove-lifecycle stale

npolshakova · 2024-07-02T13:20:20Z

@npolshakova are you still working on this?

/remove-lifecycle stale

Yep, my team is looking into this still. It looks like the last release notes PR didn't run into this issue though!

Delete this file due to a known bug kubernetes/release#3516

Signed-off-by: cloudmelon <[email protected]> Delete releases/release-1.31/release-notes/maps/pr-124320-map.yaml Update releases/release-1.31/release-notes/maps/pr-124428-map.yaml sure Co-authored-by: Nina Polshakova <[email protected]> Update releases/release-1.31/release-notes/maps/pr-124994-map.yaml Co-authored-by: Sepideh <[email protected]> Update releases/release-1.31/release-notes/maps/pr-125225-map.yaml Co-authored-by: Nina Polshakova <[email protected]> Update releases/release-1.31/release-notes/maps/pr-125333-map.yaml Co-authored-by: Nina Polshakova <[email protected]> Update releases/release-1.31/release-notes/maps/pr-125442-map.yaml Co-authored-by: Nina Polshakova <[email protected]> Update releases/release-1.31/release-notes/maps/pr-125751-map.yaml Co-authored-by: Nina Polshakova <[email protected]> Update releases/release-1.31/release-notes/maps/pr-122025-map.yaml Co-authored-by: Nina Polshakova <[email protected]> Update releases/release-1.31/release-notes/maps/pr-124994-map.yaml Update releases/release-1.31/release-notes/maps/pr-125328-map.yaml Co-authored-by: Sepideh <[email protected]> Update releases/release-1.31/release-notes/maps/pr-126012-map.yaml Co-authored-by: Nina Polshakova <[email protected]> Update releases/release-1.31/release-notes/maps/pr-126057-map.yaml Co-authored-by: Nina Polshakova <[email protected]> Update releases/release-1.31/release-notes/maps/pr-126046-map.yaml Co-authored-by: Nina Polshakova <[email protected]> Update releases/release-1.31/release-notes/maps/pr-125970-map.yaml Co-authored-by: Nina Polshakova <[email protected]> Update releases/release-1.31/release-notes/maps/pr-125894-map.yaml Co-authored-by: Nina Polshakova <[email protected]> Delete releases/release-1.31/release-notes/maps/pr-125365-map.yaml Delete this file due to a known bug kubernetes/release#3516 change draft json and md add map values release notes draft add mapping values true Update releases/release-1.31/release-notes/maps/pr-122025-map.yaml update upon the convention Co-authored-by: Nina Polshakova <[email protected]> Update releases/release-1.31/release-notes/maps/pr-126012-map.yaml Update upon convention ponctuation and past times Co-authored-by: Nina Polshakova <[email protected]>

update upon the convention Update releases/release-1.31/release-notes/maps/pr-126012-map.yaml Update upon convention ponctuation and past times Update release note release-notes-draft-v1.31.0-beta.0 release notes draft release-notes-draft-v1.31.0-beta.0 add map values change draft json and md Delete releases/release-1.31/release-notes/maps/pr-125365-map.yaml Delete this file due to a known bug kubernetes/release#3516 Update releases/release-1.31/release-notes/maps/pr-125894-map.yaml Update releases/release-1.31/release-notes/maps/pr-125970-map.yaml Update releases/release-1.31/release-notes/maps/pr-126046-map.yaml Update releases/release-1.31/release-notes/maps/pr-126057-map.yaml Update releases/release-1.31/release-notes/maps/pr-126012-map.yaml Update releases/release-1.31/release-notes/maps/pr-125328-map.yaml Update releases/release-1.31/release-notes/maps/pr-124994-map.yaml Update releases/release-1.31/release-notes/maps/pr-122025-map.yaml Update releases/release-1.31/release-notes/maps/pr-125751-map.yaml Update releases/release-1.31/release-notes/maps/pr-125442-map.yaml Update releases/release-1.31/release-notes/maps/pr-125333-map.yaml Update releases/release-1.31/release-notes/maps/pr-125225-map.yaml Update releases/release-1.31/release-notes/maps/pr-124994-map.yaml Update releases/release-1.31/release-notes/maps/pr-124428-map.yaml sure Delete releases/release-1.31/release-notes/maps/pr-124320-map.yaml Release Notes draft for k/k v1.31.0-beta.0 Signed-off-by: cloudmelon <[email protected]> Co-Authored-By: Nina Polshakova <[email protected]> Co-Authored-By: Sepideh <[email protected]>

k8s-triage-robot · 2024-09-30T14:05:26Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

npolshakova added area/release-eng Issues or PRs related to the Release Engineering subproject kind/bug Categorizes issue or PR as related to a bug. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 18, 2024

k8s-ci-robot added the needs-priority label Mar 18, 2024

npolshakova mentioned this issue Mar 18, 2024

Update release notes draft to version v1.30.0-alpha.3 kubernetes/sig-release#2449

Merged

This was referenced Mar 27, 2024

1.30 Release Notes: "Known Issues" kubernetes/kubernetes#124046

Closed

Failing regex match on release notes #3523

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 25, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 27, 2024

npolshakova mentioned this issue Jul 2, 2024

Update release notes draft to version v1.31.0-alpha.2 kubernetes/sig-release#2549

Merged

npolshakova mentioned this issue Jul 24, 2024

Update release notes draft to version v1.31.0-beta.0 kubernetes/sig-release#2575

Merged

cloudmelon added a commit to cloudmelon/sig-release that referenced this issue Jul 26, 2024

Delete releases/release-1.31/release-notes/maps/pr-125365-map.yaml

e736473

Delete this file due to a known bug kubernetes/release#3516

npolshakova mentioned this issue Sep 17, 2024

Fix empty release note parsing #3764

Merged

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2024

k8s-ci-robot closed this as completed in #3764 Oct 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release Notes Collection Picks Up Incorrect Text #3516

Release Notes Collection Picks Up Incorrect Text #3516

npolshakova commented Mar 18, 2024 •

edited

Loading

saschagrunert commented Mar 19, 2024

npolshakova commented Mar 19, 2024

saschagrunert commented Mar 21, 2024

npolshakova commented Mar 27, 2024

k8s-triage-robot commented Jun 25, 2024

saschagrunert commented Jun 27, 2024

npolshakova commented Jul 2, 2024

k8s-triage-robot commented Sep 30, 2024

Release Notes Collection Picks Up Incorrect Text #3516

Release Notes Collection Picks Up Incorrect Text #3516

Comments

npolshakova commented Mar 18, 2024 • edited Loading

What happened:

What you expected to happen:

saschagrunert commented Mar 19, 2024

npolshakova commented Mar 19, 2024

saschagrunert commented Mar 21, 2024

npolshakova commented Mar 27, 2024

k8s-triage-robot commented Jun 25, 2024

saschagrunert commented Jun 27, 2024

npolshakova commented Jul 2, 2024

k8s-triage-robot commented Sep 30, 2024

npolshakova commented Mar 18, 2024 •

edited

Loading