Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render list of releases using a content adapter #46426

Open
sftim opened this issue May 17, 2024 · 11 comments
Open

Render list of releases using a content adapter #46426

sftim opened this issue May 17, 2024 · 11 comments
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented May 17, 2024

This is a Feature Request

What would you like to be added
Partially Revise https://kubernetes.io/releases/ to have some pages rendered using a content adapter.

For example:

Why is this needed
It provides a better place and “one stop shop” for people who want to find out about our releases, new and old.

Comments
/area web-development
/sig release

We would need to be using Hugo v0.126 or later.

@sftim sftim added the kind/feature Categorizes issue or PR as related to a new feature. label May 17, 2024
@k8s-ci-robot k8s-ci-robot added area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes sig/release Categorizes an issue or PR as relevant to SIG Release. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 17, 2024
@sftim
Copy link
Contributor Author

sftim commented May 17, 2024

We should only make this change if we think it's a good idea.

@dipesh-rawat
Copy link
Member

+1 from me for this. This looks like a nice feature to incorporate.

@PushkarJ
Copy link
Member

PushkarJ commented May 26, 2024

This is a great idea. I want to try this for kubernetes/sig-security#1 to auto-generate CVE pages.

Can I request SIG Docs to create a container image that supports this new feature in v0.126.0? Getting this error right now:

personal-macbook:website pushkarj$ make container-serve
"docker" run --rm --interactive --tty --volume "/Users/pushkarj/opensource-ftw/kubernetes/website:/src:ro,Z" --cap-drop=ALL --cap-add=AUDIT_WRITE --read-only --mount type=tmpfs,destination=/tmp,tmpfs-mode=01777 -p 1313:1313 gcr.io/k8s-staging-sig-docs/k8s-website-hugo:v0.126.0-663380dd60a2 hugo server --buildFuture --environment development --bind 0.0.0.0 --destination /tmp/hugo --cleanDestinationDir --noBuildLock
Unable to find image 'gcr.io/k8s-staging-sig-docs/k8s-website-hugo:v0.126.0-663380dd60a2' locally
docker: Error response from daemon: manifest for gcr.io/k8s-staging-sig-docs/k8s-website-hugo:v0.126.0-663380dd60a2 not found: manifest unknown: Failed to fetch "v0.126.0-663380dd60a2" from request "/v2/k8s-staging-sig-docs/k8s-website-hugo/manifests/v0.126.0-663380dd60a2".

@sftim
Copy link
Contributor Author

sftim commented May 29, 2024

I've messaged you @PushkarJ about how to preview the site with a different Hugo version.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 28, 2024
@sftim
Copy link
Contributor Author

sftim commented Aug 28, 2024

I think this'd be a really nice idea.
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 28, 2024
@sftim
Copy link
Contributor Author

sftim commented Sep 23, 2024

Any takers?

@xmudrii
Copy link
Member

xmudrii commented Sep 30, 2024

@sftim Do we have any example for this so far? I could look into it if we have some example how it is done

@sftim
Copy link
Contributor Author

sftim commented Sep 30, 2024

We're not using this functionality as far as I know. Not yet.

@sftim
Copy link
Contributor Author

sftim commented Oct 16, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 16, 2024
@sftim
Copy link
Contributor Author

sftim commented Oct 21, 2024

@xmudrii if you'd like to work on this, or to introduce someone with an interest, I reckon SIG Docs can coach them. I may well have capacity in the 2nd part of November (2024).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

6 participants