Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More describe-locks test #1137

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Sep 5, 2024

Made three changes to test describe-locks more throughout:

  • 9b9048b: DescribeLocks now returns a sorted slice of ProjectDesc, which is also a collection of sorted PhaseDescs.
    Previously, project and phase ordering within a describe-locks response was dependent on how the underlying Go map stored and returned projects and phases, which resulted in flaky test when we had to test describe-locks with multiple projects and phases.
    This fixes that by sorting projects and phases before generating a response.
  • 40adddb: Enhances the test to cover multiple projects- previously we tested with only one project myproject1. Now we test with two.
  • 26c0850: Enhances the test to cover multiple phases- previously we tested only with production. We now have staging too.

@pirlodog1125 pirlodog1125 merged commit f4a581d into kufu-ai:master Sep 6, 2024
5 checks passed
@mumoshu mumoshu deleted the more-describe-locks-test branch September 6, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants