Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More permissive data storage in the FC Level #199

Open
kkappler opened this issue Mar 22, 2024 · 0 comments
Open

More permissive data storage in the FC Level #199

kkappler opened this issue Mar 22, 2024 · 0 comments
Labels
question Further information is requested

Comments

@kkappler
Copy link
Collaborator

kkappler commented Mar 22, 2024

  • FCs are currently stored as complex, however, it is possible that one may wish to store amplitude, phase instead of real/imaginary, or that they may wish to store other features at the FC level, that are real, or boolean valued.

  • The FC Level Dataset also assumes linear spaced frequencies, but we may wish to calculate and store some features of FCs (such as cross-spectra) on log-spaced bands. To make this work we would want from_xarray() to store the coordinates of the incoming array somewhere, and access them when we call to_xarray()

It is possible that we should we consider a frequency domain features layer instead of modifying the FC layer.

Possibly we want to be able to define the dtype for a group based on the data passed in:

SUPPORTED_DTYPES = {"complex":complex,"float":float, "int":int}

and then pass a kwarg to add_channel such as dtype="complex"
then

dataset = self.hdf5_group.create_dataset(
                fc_name,
                data=fc_data,
                dtype=SUPPORTED_DTYPES[dtype],
                chunks=chunks,
                maxshape=max_shape,
                **self.dataset_options,
            )
@kkappler kkappler added the question Further information is requested label Mar 22, 2024
@kkappler kkappler changed the title Consider allowing real-valued data storage in the FC Level More permissive data storage in the FC Level Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant