Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radio Group Cont #94

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Radio Group Cont #94

merged 4 commits into from
Jan 15, 2025

Conversation

jay-kunaico
Copy link
Contributor

Updates for contexts

jay-kunaico and others added 2 commits January 9, 2025 12:53
@jay-kunaico @toan-kunaico @thejackshelton
New RadioGroup updates
33a9882 
Co-authored-by: toan-kunaico <[email protected]>
Co-authored-by: Jack Shelton <[email protected]>
@jay-kunaico
Radio Group edits
5007871
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f68654c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jay-kunaico jay-kunaico marked this pull request as draft January 10, 2025 21:25
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 10, 2025 •
edited
Loading

Deploying qwik-design-system with  Cloudflare Pages  Cloudflare Pages

Latest commit: f68654c
Status: ✅  Deploy successful!
Preview URL: https://c77829bf.qwik-design-system.pages.dev
Branch Preview URL: https://radio-group-cont.qwik-design-system.pages.dev

View logs

@jay-kunaico jay-kunaico requested review from toan-kunaico and thejackshelton-kunaico and removed request for toan-kunaico January 15, 2025 13:00
@thejackshelton-kunaico thejackshelton-kunaico marked this pull request as ready for review January 15, 2025 19:51
thejackshelton-kunaico
thejackshelton-kunaico approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@thejackshelton-kunaico thejackshelton-kunaico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jay-kunaico merging this in now. For the Rating component in C1 we likely need keyboard navigation on these radio groups.

Also a horizontal radio group. Not sure which is the more common one, I'd assume vertical?

@thejackshelton-kunaico thejackshelton-kunaico merged commit 421e04e into main Jan 15, 2025
1 check passed
@thejackshelton-kunaico thejackshelton-kunaico deleted the radio-group-cont branch January 15, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejackshelton-kunaico thejackshelton-kunaico thejackshelton-kunaico approved these changes

@toan-kunaico toan-kunaico Awaiting requested review from toan-kunaico

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jay-kunaico @thejackshelton-kunaico