Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code not working #93

Open
mtliou opened this issue Jul 24, 2024 · 4 comments
Open

Code not working #93

mtliou opened this issue Jul 24, 2024 · 4 comments

Comments

@mtliou
Copy link

mtliou commented Jul 24, 2024

This code can't solve simple 24 games like: "4 4 6 8" Is the code working for anyone else?

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@kyegomez
Copy link
Owner

@mtliou hey try again please, I just shipped a new update

@moht355
Copy link

moht355 commented Sep 7, 2024

Yeah idk what you're doing but it's not working... I've spent so much time on this but I'm now seeing all the negative comments regarding the code. Has it ever worked for anyone?

"2024-09-07T16:59:05.621977-0400 Finished DFS for state:

Your task: is to use 4 numbers and basic arithmetic operations (+-*/) to obtain 24 in 1 equation, return only the math

{
"final_thoughts": [
{
"thought": "One common set of numbers used in these types of problems is 8, 3, 3, and 1. Let's see if we can achieve 24 using these numbers: \(8 \\times (3 - (3 - 1)) = 8 \\times 1 = 8\), which doesn't work. Let's try another approach.\n\nAnother set is 8, 3, 2, and 1: \(8 \\times (3 - (2 - 1)) = 8 \\times 2 = 16\), which also doesn't work. However, using 8, 3, 2, and 1 but in a different operation: \((8 \\div (3 - 1)) \\times 3 = (8 \\div 2) \\times 3 = 4 \\times 3 = 12\), which still doesn't work. I need to re-evaluate my approach to achieve exactly 24.\n\nLet's try another set: 4, 4, 4, 1: \((4 + 4) \\times (4 - 1) = 8 \\times 3 = 24\). This seems to work.",
"evaluation": 0.9
},
{
"thought": "One possible solution using the numbers 8, 3, 3, and 1 is: \( (8 - 3) \times (3 + 1) = 24 \).",
"evaluation": 0.9
},
{
"thought": "To solve the problem of obtaining 24 using four numbers and basic arithmetic operations, I need to first identify the four numbers. Since the numbers are not provided, I will assume a common set of numbers often used in such puzzles, such as 1, 3, 4, and 6. The goal is to combine these numbers using addition, subtraction, multiplication, and division to reach exactly 24. A common solution for this set is: (6 / (1 - (3 / 4))) = 24. This equation uses division and subtraction to manipulate the numbers to achieve the target number.",
"evaluation": 0.9
},
{
"thought": "One possible equation using the numbers 8, 3, 3, and 1 to obtain 24 is: (8 / (3 - (1 / 3))) = 24. This involves dividing 8 by the result of the subtraction of 1/3 from 3, which simplifies to 24.",
"evaluation": 1.0
}
],
"pruned_branches": [],
"highest_rated_thought": {
"thought": "One possible equation using the numbers 8, 3, 3, and 1 to obtain 24 is: (8 / (3 - (1 / 3))) = 24. This involves dividing 8 by the result of the subtraction of 1/3 from 3, which simplifies to 24.",
"evaluation": 1.0
}
}"

@kyegomez
Copy link
Owner

kyegomez commented Sep 8, 2024

Yeah idk what you're doing but it's not working... I've spent so much time on this but I'm now seeing all the negative comments regarding the code. Has it ever worked for anyone?

"2024-09-07T16:59:05.621977-0400 Finished DFS for state:

Your task: is to use 4 numbers and basic arithmetic operations (+-*/) to obtain 24 in 1 equation, return only the math

{

"final_thoughts": [

    {

        "thought": "One common set of numbers used in these types of problems is 8, 3, 3, and 1. Let's see if we can achieve 24 using these numbers: \\(8 \\\\times (3 - (3 - 1)) = 8 \\\\times 1 = 8\\), which doesn't work. Let's try another approach.\n\nAnother set is 8, 3, 2, and 1: \\(8 \\\\times (3 - (2 - 1)) = 8 \\\\times 2 = 16\\), which also doesn't work. However, using 8, 3, 2, and 1 but in a different operation: \\((8 \\\\div (3 - 1)) \\\\times 3 = (8 \\\\div 2) \\\\times 3 = 4 \\\\times 3 = 12\\), which still doesn't work. I need to re-evaluate my approach to achieve exactly 24.\\n\nLet's try another set: 4, 4, 4, 1: \\((4 + 4) \\\\times (4 - 1) = 8 \\\\times 3 = 24\\). This seems to work.",

        "evaluation": 0.9

    },

    {

        "thought": "One possible solution using the numbers 8, 3, 3, and 1 is: \\( (8 - 3) \\times (3 + 1) = 24 \\).",

        "evaluation": 0.9

    },

    {

        "thought": "To solve the problem of obtaining 24 using four numbers and basic arithmetic operations, I need to first identify the four numbers. Since the numbers are not provided, I will assume a common set of numbers often used in such puzzles, such as 1, 3, 4, and 6. The goal is to combine these numbers using addition, subtraction, multiplication, and division to reach exactly 24. A common solution for this set is: (6 / (1 - (3 / 4))) = 24. This equation uses division and subtraction to manipulate the numbers to achieve the target number.",

        "evaluation": 0.9

    },

    {

        "thought": "One possible equation using the numbers 8, 3, 3, and 1 to obtain 24 is: (8 / (3 - (1 / 3))) = 24. This involves dividing 8 by the result of the subtraction of 1/3 from 3, which simplifies to 24.",

        "evaluation": 1.0

    }

],

"pruned_branches": [],

"highest_rated_thought": {

    "thought": "One possible equation using the numbers 8, 3, 3, and 1 to obtain 24 is: (8 / (3 - (1 / 3))) = 24. This involves dividing 8 by the result of the subtraction of 1/3 from 3, which simplifies to 24.",

    "evaluation": 1.0

}

}"

What's not working? Can you be more specific? It seems to be working just fine???

@mtliou
Copy link
Author

mtliou commented Sep 11, 2024

we both got the same wrong result. Here: (8 / (3 - (1 / 3))) = 24. This is erroneous. Your output is always wrong. I can't locate what's wrong with you code but it seems to have significantly worse performance than the paper's code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants