Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the CustomStateCheck feature #1616

Closed
4 tasks done
janmedrek opened this issue Jun 7, 2024 · 0 comments · Fixed by #1708
Closed
4 tasks done

Deprecate the CustomStateCheck feature #1616

janmedrek opened this issue Jun 7, 2024 · 0 comments · Fixed by #1708
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@janmedrek
Copy link
Contributor

janmedrek commented Jun 7, 2024

Description

With the separation of the statuses that will be introduced in #1471, there is no longer a need to rely on the Module resources to determine the overall status of the Kyma Module.

Instead, we should only take into the account Manifest State of the module, thus this feature is no longer required and should be deprecated.

Reasons

We want a clear separation of statuses without going into module-related resources and logic.

Acceptance Criteria

  • Deprecate feature in CR Documentation and all other places where it is mentioned
  • Create corresponding Follow-Up Issues:
    • Drop it from API - makes sure the issues are linked here
    • Drop the feature implementation from the KLM

Feature Testing

No response

Testing approach

No response

Attachments

No response

@janmedrek janmedrek added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 7, 2024
@jeremyharisch jeremyharisch changed the title Drop the CustomStateCheck feature Deprecate the CustomStateCheck feature Jul 22, 2024
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP self-assigned this Jul 23, 2024
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP removed their assignment Jul 24, 2024
kyma-bot pushed a commit to kyma-project/template-operator that referenced this issue Jul 30, 2024
**Description**

Add deprecation note for the `customStateCheck` attribute:

**Related issue(s)**

kyma-project/lifecycle-manager#1708
kyma-project/lifecycle-manager#1616

---------

Co-authored-by: Małgorzata Świeca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants