Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an E2E Test verifying the expected labels on KymaCR #1949

Open
2 tasks
c-pius opened this issue Oct 10, 2024 · 0 comments
Open
2 tasks

Implement an E2E Test verifying the expected labels on KymaCR #1949

c-pius opened this issue Oct 10, 2024 · 0 comments
Labels
area/quality Related to all activites around quality

Comments

@c-pius
Copy link
Contributor

c-pius commented Oct 10, 2024

Description

We currently don't have an E2E test that verifies that the watched-by label is present with the expected value kyma on the SKR KymaCR. We should either find an existing E2E test that can be extended with this, or we create an entire E2E test that is about metadata and verifies expected labels on multiple resources.

This also needs to consider that we sometimes already have such verification in E2E tests. E.g., #1913 includes a verification that managed-by label is present on all raw manifest resources and tests that those are removed once the module is unmanaged.

Ideally, we could even think about this as a "sanity check" E2E test where the checks can be re-used in the more detailed E2E tests.

Reasons

Some labels are significant to our implementations (e.g., the watched-by label). We need to make sure that those are consistent as expected.

Acceptance Criteria

  • watched-by label verified in E2E tests
  • TODO: discuss what further labels we would want to address

Feature Testing

No response

Testing approach

No response

Attachments

No response

@c-pius c-pius added the area/quality Related to all activites around quality label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Related to all activites around quality
Projects
None yet
Development

No branches or pull requests

1 participant