Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ModuleCatalog] Support .spec.resources #53

Closed
7 tasks done
c-pius opened this issue Oct 1, 2024 · 0 comments · Fixed by #73
Closed
7 tasks done

[ModuleCatalog] Support .spec.resources #53

c-pius opened this issue Oct 1, 2024 · 0 comments · Fixed by #73
Assignees

Comments

@c-pius
Copy link
Contributor

c-pius commented Oct 1, 2024

Description

Support the resources introduced via kyma-project/lifecycle-manager#1842. The module config file should support a new field that is than written into .spec.resources.

Reasons

Support the resources field introduced via kyma-project/lifecycle-manager#1842

Acceptance Criteria

  • When adding entries to module-config.yaml
    resources:
    - name: <string>
      link: <link>
  • Then the entry is written to the generated module template as:
    spec:
      resources:
       - name: <string>
         link: <link>
  • When adding no entries to module-config.yaml resources, then the entry is written to the generated module template as:
    spec:
      resources:
       - name: rawManifest
         link: <link from manifest field in module-config>
  • There should always be an entry for resources in generated module template
  • Validations include
    • name must be unique
    • link must be a valid web URL (http* and not file://)

Attachments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants