Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kyse.link in kysely.dev homepage instead of the outdated playground it now has #1149

Open
GitMurf opened this issue Sep 16, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@GitMurf
Copy link

GitMurf commented Sep 16, 2024

I am brand new to Kysely and looking to implement in our new sqlite project. I was on the homepage and started playing with the playground on the homepage and noticed orWhere is how to do groupings of OR clauses. I later was looking through the advanced docs and saw reference to the eb.or nomenclature and then stumbled across this PR for the migration to expression builder v2: #565

image

After some investigation I realized the eb.or syntax seemed to be the correct syntax for today and that the home page playground must just be connected to an older version of the API.

To avoid any confusion between the playground and the docs for new users like myself, it would be nice if that playground on the homepage could be updated to the current version / API.

Great product! Looking forward to integrating in our project.

@koskimas
Copy link
Member

That playground should just be removed. It doesn't use https://kyse.link but some other thing that was thrown together by the person that implemented the first version of kysely.dev.

If you go to the example section, the "correct" playground is used there.

@GitMurf
Copy link
Author

GitMurf commented Sep 17, 2024

@koskimas as an fyi I will say it was nice as a new prospective user to have a playground on the homepage. If the correct playground is embeddable then I recommend replacing it, otherwise a link to the playground.

Do you want me to close this issue? Or want to leave it open as a reminder to fix the homepage?

@koskimas
Copy link
Member

Sorry, I meant we should replace the playground with kyse.link and remove the current one from the codebase. Let's leave this open. I'll rename the issue.

@koskimas koskimas changed the title Kysely.dev homepage playground example seems to be on old version pre-eb v2 (ie. orWhere) Use kyse.link in kysely.dev homepage instead of the outdated playground it now has Sep 17, 2024
@igalklebanov igalklebanov added the documentation Improvements or additions to documentation label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants