Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore using the new JAX FFI instead of custom call based on pybind11 #132

Open
Luthaf opened this issue Aug 11, 2024 · 0 comments
Open

Comments

@Luthaf
Copy link
Contributor

Luthaf commented Aug 11, 2024

JAX recently added a proper FFI, which removes the need to create Python bindings for the functions we want to call (removing the need for something like #107).

See the documentation here: https://jax.readthedocs.io/en/latest/ffi.html

I'm not sure what the consequences for pre-built sphericart-jax wheels are. This will depend on how stable the ABI used for FFI is. We might have to do the same trick as with PyTorch versions (having multiple copies of the sphericart-jax shared library, each compiled against a different JAX version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant