Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wagtail 4 support #187

Open
Tijani-Dia opened this issue Sep 8, 2022 · 1 comment
Open

Add Wagtail 4 support #187

Tijani-Dia opened this issue Sep 8, 2022 · 1 comment

Comments

@Tijani-Dia
Copy link

We've recently upgraded one of our projects which uses this package to Wagtail 4 but we're getting errors with 2fa when logging in to the admin. It looks like it may be related to this line here:

wagtail-2fa/src/wagtail_2fa/templates/wagtail_2fa/otp_form.html

Line 9 in 0b2b6e7

<link rel="stylesheet" href="{% static 'wagtailadmin/css/layouts/login.css' %}" type="text/css" />
.

Thanks a lot for this useful package by the way.
th3hamm0r added a commit to th3hamm0r/wagtail-2fa that referenced this issue Nov 21, 2022
@th3hamm0r
Use new template for wagtail >= 4
be32c6d 
This fixes crashes due to a reference to a non-existent CSS file, but
also tries to adapt the html based on the latest login.html.

See labd#187
This was referenced Nov 21, 2022
Merged
Merged
@zerolab
Copy link

zerolab commented Jan 17, 2023

Looks like this was fixed via #195, #196 (and add some tweaks in #203), so it can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zerolab @Tijani-Dia