diff --git a/RELEASE-NOTES-1.1.md b/RELEASE-NOTES-1.1.md index 8300ff4..3066652 100644 --- a/RELEASE-NOTES-1.1.md +++ b/RELEASE-NOTES-1.1.md @@ -38,8 +38,13 @@ risk! * Removed unnecessary modules. * Fixed CodeMirror glitch. * (issue #26) Removed unneeded `wp` prefix from `hide-if`. +* (issue #32) Fixed "access to private variable of parent class" in + `SkinLakeus.php` by dropping unneeded `BagOStuff $localServerObjectCache` + dependency. * … +12345678901234567890123456789012345678901234567890123456789012345678901234567890 + ### Action API changes * … diff --git a/includes/SkinLakeus.php b/includes/SkinLakeus.php index 84edba5..3b11475 100644 --- a/includes/SkinLakeus.php +++ b/includes/SkinLakeus.php @@ -2,24 +2,11 @@ namespace MediaWiki\Skins\Lakeus; -use BagOStuff; -# use MediaWiki\Html\TemplateParser; // Namespaced in 1.40.0 # use MediaWiki\SiteStats\SiteStats; // Namespaced in 1.41.0 use SiteStats; use SkinMustache; -use TemplateParser; class SkinLakeus extends SkinMustache { - /** - * @param BagOStuff $localServerObjectCache - * @param array $options - */ - public function __construct( BagOStuff $localServerObjectCache, array $options ) { - parent::__construct( $options ); - - $this->templateParser = new TemplateParser( $this->options['templateDirectory'], $localServerObjectCache ); - } - /** * Extends the getTemplateData function to add a template key 'html-myskin-hello-world' * which can be rendered in skin.mustache using {{{html-myskin-hello-world}}} diff --git a/skin.json b/skin.json index 616176d..61deaaa 100644 --- a/skin.json +++ b/skin.json @@ -229,9 +229,6 @@ "ValidSkinNames": { "lakeus": { "class": "MediaWiki\\Skins\\Lakeus\\SkinLakeus", - "services": [ - "LocalServerObjectCache" - ], "args": [ { "name": "lakeus",